Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing oauth if username case changed #40

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fixed failing oauth if username case changed #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oauth/authorize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@

// print the authorization code if the user has authorized your client
$is_authorized = ($_POST['authorized'] === 'Authorize');
$server->handleAuthorizeRequest($request, $response, $is_authorized,$_SESSION['uid']);
$server->handleAuthorizeRequest($request, $response, $is_authorized,strtolower($_SESSION['uid']));

if ($is_authorized)
{
Expand Down
2 changes: 1 addition & 1 deletion oauth/connexion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
// Remove every html tag and useless space on username (to prevent XSS)
$user=strip_tags(trim($_POST['user']));

$user=$_POST['user'];
$user=strtolower($_POST['user']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'm unclear why $user is being set to the result of strip_tags(trim()) and immediately re-set to the POST value, but I didn't want to try and make both changes at once since that's not quite relevant to this particular change.

$password=$_POST['password'];

// Open a LDAP connection
Expand Down