A nicer user interface #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catfriend1
reviewed
Apr 20, 2020
| { | ||
| // Check received data length (to prevent code injection) | ||
| if (strlen($_POST['user']) > 15) |
There was a problem hiding this comment.
The max username length should be increased to 64 . Because we have Windows AD user accounts "prename.name" in our directory.
Catfriend1
reviewed
Apr 20, 2020
| <td align="center"> | ||
| <div class="LoginTitle">LDAP Authentification</div> | ||
|
|
||
| $prompt_template = new DOMDocument(); |
There was a problem hiding this comment.
It should be also updated in the README.md that this line requires the apt package "php-dom" to be installed.
apt-get -y install php-dom
Catfriend1
suggested changes
Apr 20, 2020
| <div id="form_credentials"> | ||
| <h1>LDAP Authentication</h1> | ||
| <div id="form_icon_prompt"> | ||
| <img src="./prompt_icon.png" alt="authentication icon" > |
There was a problem hiding this comment.
Must be: src="./images/prompt_icon.png"
| <div id="form_credentials"> | ||
| <h1>LDAP Authentication</h1> | ||
| <div id="form_icon"> | ||
| <img src="./auth_icon.png" alt="authentication icon" > |
There was a problem hiding this comment.
Must be: src="./images/auth_icon.png"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
This pull request implements a more user friendly interface.
Overview
connexion.phpfile merged with theindex.php