Daisy UI 4 staging #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5e0b409
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://127ebeca.saasstarter.pages.dev |
| Branch Preview URL: | https://daisy-ui-4-staging.saasstarter.pages.dev |
Hovering "sign in" button needs a fix. Loses it's color on hover. |
|
I would say we should also update our theme with custom error and success colours. They new defaults don't look good with the rest of the theme. Before/after examples here: Before After Before After |
|
@keybits Mind making these fixes? You can make them in either branch. Just had to use the second one to get Cloudflare to spin up a preview. |
|
Thanks for checking. Happy to make the changes. (I kind of like the brighter red though 😉) Will update in the next day or two. |
|
@keybits I also like the brighter red 😉😉 |
|
They are nice colors, but they don't work with the default theme. Saturation is way off -- everywhere else we use desaturated colors. And readability is poor with our default font color. |
Matches previous theme colors - see #38 (comment)
Merged
|
Thanks @keybits ! |
tanel-n
added a commit
to tanel-n/IAS0320_proto
that referenced
this pull request
Nov 30, 2024
* Deeplink to docs * Improve blog page, including responsive mobile support * Update README.md * Create LICENSE * Grammar * design tweaks * Update README.md * Update README.md * Design tweaks * improve design of admin portal * Design improvements * Update README.md * Update README.md * Add link from admin console back to marketing * Compress image * compress image * Update deps * Typo and color * Update homepage copy * Home page tweak * Rename Admin -> User * Update README.md * Github Actions build CI (#7) * New Github Actions build check * And env vars for build * Add build status badge, and license badge * Fix bug in blog caused by upgrading SvelteKit. * More robust fix for prior bug. Don't want to match prefix or /post matches /post2 * Do I need a perfect pagespeed insights score? No. Do I want one? Yes! * Update README.md * Update README.md * npm run format * Add format check command and CI (#10) * Add format check command and CI * Add formatting/prettier status badge * Fix typescript linting * Fix all linting errors * Add linting to CI * Update README.md with Lint CI and git hook instructions * Update README devX section for CI and hooks * Remove non-direct dependency * Workaround for supabase-community/auth-ui#230 * Update README.md * Update README.md * Update README.md * Update README.md * Line height tweak * Spacing tweaks * fix linting, CI, and ESLint+VSCode setup * Fix all eslint errors * update README to fix typos + extension info and finish conversion of repo into TS format * Fix CriticalMoments/CMSaasStarter#13 We were telling users they had oauth just because they weren't logged in with a password. That's not necessarily true, they can log in via a link (verify email link, magic link). Make the oauth part of the message conditional on knowing for certain they logged in with oauth. Also clean up copy and style. * fix all type errors * fix bug and naming of form response, plus minor fixups for typechecking PR * Improved pricing boilerplate with FAQ template and grid template. Icons were public domain icons. * Add "check" to README to match CI * tweak layout and demo content. * Create SECURITY.md * Bump undici and @sveltejs/kit Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit). These dependencies need to be updated together. Updates `undici` from 5.26.5 to 5.28.3 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.26.5...v5.28.3) Updates `@sveltejs/kit` from 1.30.3 to 1.30.4 - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/@sveltejs/[email protected]/packages/kit/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/[email protected]/packages/kit) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: "@sveltejs/kit" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Account title not changing bug fix * Contact Us functionality saving to a datanbase * Add contact us to marketing content * Cleanup blog engine: - Posts into typescript - Post type into non-global - Remove repeated date parsing code - Remove repeated sorting code - Proper 404 errors on bad urls * Fix error page background color. * Don't pre-render the rss. Need the domain origin which isn't available at pre-render time. * remove log, and fix layout on big monitors * Add testing CI. Yes, I should have more tests built in. But this way is at least setup for testing when I do. Add dev-ex description to README, and improve setup instructions. * Update readme * Update readme * Fix name of CI test file * Update homepage: icons, copy, docs links * Fix for CriticalMoments/CMSaasStarter#25 Smoother setup for initial run of local dev env. * Add a blog post entry linking to the big blog post explaining how/why we built this template. Includes useful best practices for how to customize this template. * Weird cloudflare issue isn't serving the compiled JS for this page. I see it rendered, but get expired headers every time. * Wild bug. - Compiled CSR js uses a hash of the page as name - DNS based ad blockers (NextDNS) detect that as ad uri, block it Changing content, should change hash. Testing on branch before merge. * Bump jose from 4.15.4 to 4.15.5 Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md) - [Commits](panva/jose@v4.15.4...v4.15.5) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Cleaner sample blog content. The one fake post wasn't clear it was fake and was confusing. * Update README.md * Change tailwind bottom margin to padding for layouts * Add more meta tags into head on blog page for better facebook and twitter seo * Update daisyUI and Tailwind * Updates for daisyUI 4 saadeghi/daisyui#2507 * Run formatting on main * Add CI for PRs * Fix theme colors Matches previous theme colors - see CriticalMoments/CMSaasStarter#38 (comment) * add cookie warning on pages that create cookies * Move config into code. People were getting tripped up on ENV var, and we content in code all over. No need for a second content in env concept. Resolves CriticalMoments/CMSaasStarter#44 * Limit profile field inputs * Bump github Action version to fix Actions warning * Add extensions to readme and homepage * npm audit fix * migrate to new supabase ssr auth package * add forgotten lock file update * add stripe_customers definitions * Fix a security issue: supabase/supabase#22381 Details: - CMSaaSStarted followed the offical SvelteKit Supabase docs here: https://supabase.com/docs/guides/getting-started/tutorials/with-sveltekit - Unforunately the server side helper getSession was not validtion the JWT token, which was caught and fixed in the docs here: supabase/supabase#22381 - There were a few improvements/cleanups since the fix, which we integrated as well, see change history here: https://github.com/supabase/supabase/commits/master/apps/docs/content/guides/getting-started/tutorials/with-sveltekit.mdx We're now back up to date with the supabase suggested format here: https://supabase.com/docs/guides/getting-started/tutorials/with-sveltekit * don't put id in strype_customers table type definitions * fix amr not existing on user object * Move the pricing FAQ/table into only the pricing page. Link to it from other uses of pricing module. Cleaner this way. * Update SEO. - Add LD+JSON for the main website, and blog posts - Improve descriptions for main page and pricing page * chore: format all files * refactor: `$ npm run format` * Add missing customer table to DB defs. New eslint catches this * Update deps (and one formatting fix mixed in) * Fix blog layout. It previously didn't update title and headers when navigating between blog posts. Made the content reactive to url so now it does. * Sveltekit 2 migration! (#76) * Sveltekit 2 migration! Mostly just running `npx svelte-migrate@latest sveltekit-2` and fixing package conflicts. Use @supabase/auth-helpers-sveltekit to ^0.11 to avoid supabase/auth-js#888 * Filename correction (README.md) (#79) pricing.js → pricing_plans.ts * Update README.md (#82) * Update README.md (#86) Update README.md with header and template docs * Update README.md * Update README.md (#91) * Update README.md Remove link to image in header * Update README.md * Update README.md (#92) * Update README.md * Update README.md * Bump ws from 8.17.0 to 8.17.1 (#93) Bumps [ws](https://github.com/websockets/ws) from 8.17.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.17.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add a vercel deployment button, and cleanup docs a bit (#96) Add a vercel deployment button, and cleanup docs a bit * Update Vercel Env Vars (#97) Remove site name and owner, as these were moved into typescript, like other content. * Add misspell utility to check for spelling errors * Fix typos found by new spelling check tool * Update README.md with vercel hosted demo page * Improve readme: fixed links, local misspell * Add admin mailer. (#103) * Add admin mailer. Fixes CriticalMoments/CMSaasStarter#83 This was a nightmare - Nodemailer worked great, but Cloudflare doesn't allow full node.js and optional imports are a pain - Cloudflare a big fat dirty liars. Give an API that can only be tested on server, then once you finally get it working after 20 deploys, it's canceled. https://blog.cloudflare.com/sending-email-from-workers-with-mailchannels/ Resend is great: up and running in 5 mins. * Email Support (#104) * Add a tool to email folks, mostly users. Includes - templating system using svelte components - support for plaintext and html - welcome email as demo and template * Add docs for new email features, and cleanup the welcome email a bit * Add email to marketing page bugs: * Fix new profile logic * Consider errors in newProfile assessment * Check email is verified before sending welcome email (#105) * Check email is verified before sending welcome * Fix email verification check: works with oauth and email auth * Clean up the mailer with new email user function that handles verified emails (#106) * Site Wide Search Feature + Mail cleanup Clean up the mailer with new email user function that handles verified emails New site wide search features. Does search in JS for super fast performance. Compiles the search index once on deploy to keep runtime overhead low. `nom run build` will generate the files needed for search indexing * Fix async issue that only occures on serverless environments * Tweaks to search, and an open source card on markting page * Keyboard support for site search * Swap fuse for lunr (#112) * Swap fuse for lunr. Lunr has real inverted search index, and better word matching (price -> pricing). * Revert "Swap fuse for lunr (#112)" This reverts commit d9cef83. Honestly, liked fuse search results more. * Move search index building into vite plugin, where we can assert it runs AFTER the pages are cached. * Add json extension for a valid content-type, which also tells Cloudflare to gzip the content: https://developers.cloudflare.com/speed/optimization/content/brotli/content-compression/ Also: give more relevance to title and description over body * Add ability to unsubscribe from emails (issue 107) * Fix linting errors * Fix lint errors * Use WebsiteName from config in nav bar * Match file name login_config.ts * Fixes CriticalMoments/CMSaasStarter#117 * Cleanup settings design a little. The green buttons were ugly. Also a few string tweaks. * Design tweaks * Made button optional in the settings page * dynamic settings title * optionally skip create profile step * feat: add sitemap.xml * format * Adding ./checks.sh for contributors, and easier dev-tool setup * prerender sitemap * Update README.md * Merge master into ssr branch * Get up to date with the SB SK guide: https://supabase.com/docs/guides/auth/server-side/sveltekit Supress warnings that are not needed: supabase/auth-js#888 (comment) * Bit more auth checking. Next step it to get it fully up to https://supabase.com/docs/guides/auth/server-side/sveltekit * More idiomatic supabase auth following https://supabase.com/docs/guides/auth/server-side/sveltekit Differences: - only run the auth layout under /account and /login, want fast unauthed marketing pages with no JS - Be even more explicit in maing getSession safe by not calling it on the server at all * Don't recall safeGetSession, already in the hook * Bump deps for secuirty issues * Inline CSS for faster first page loads. * update deps - Security patch in svelte: https://github.com/CriticalMoments/CMSaasStarter/security/dependabot/13 - Glob now explicit dev dependency, was implicit before. Fix import format. - Update everything while we're at it * Move glob back to v10. v11 requires node 22, and doesn't support all current maintained/stable node versions * Fix a redirect loop. We were inconsistent for how we redirected login to account and vice versa. A expired session could enter redirect loop. Also dont redirect from authHandler. I don't want to leave any page to account when logged in, just /login/* * Fix sign out page - Ugly layout - If we tried to render server side it errorer (no goto) - It was signing out on load, not on mount * Fixes CriticalMoments/CMSaasStarter#145 More error logging on unexpected errors. * Adds a small padding at the bottom to prevent lack of space for descenders Adds a small padding at the bottom to prevent lack of space for descenders, leading to descenders like "g" and "p" being cut off at the bottom. (Caused by bg-clip-text and text-transparent.) * Adds small paddings at the bottom to prevent lack of space for descenders Adds a small padding at the bottom to prevent lack of space for descenders, leading to descenders like "g" and "p" being cut off at the bottom. (Caused by bg-clip-text and text-transparent.) * Balance the extra space created Adjust the bottom margin or the top margin of the next element to balance the extra space created by pb * Bump rollup from 4.21.2 to 4.22.5 Bumps [rollup](https://github.com/rollup/rollup) from 4.21.2 to 4.22.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.2...v4.22.5) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Bump vite from 5.4.2 to 5.4.8 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.2 to 5.4.8. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.8/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.8/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Add PostHog analytics to readme * migration to Svelte 5 * Resolve error in marketing layout * Fix type error in change password page * Resolve type error in create profile page * Update packages and format * Use import style for Node 23+ * Use TS in one file where we missed it * Add a tbody. This isn't ideal as we're diverting from the tested template... but I'll test it. Should ideally remove if this is fixed: sveltejs/svelte#9785 * Fix svelte check errors * Fix formatting * Fix out mailer for svelte 5 * Svelteize the page. * Move to svelte 5 $effect * $effect https://svelte.dev/docs/svelte/v5-migration-guide#Migration-script-run * Move email templates to handlebars.js remove tbody tags we added for svelte compatibility * Fix docs -- correct filenames * Revert changes made to email template for svelte compat. Using handlebars now * Don't auto format plaintext email templates * Remove unneeded exclude * Upgrade cookie for dependabot warning * Rename env template for vercel compat * Fix CriticalMoments/CMSaasStarter#169 * Move analytics to it's own README Add GA links * Update README.md * Bump deps * update sponsor --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: scosman <[email protected]> Co-authored-by: Owen Versteeg <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mgenovski <[email protected]> Co-authored-by: Charl <[email protected]> Co-authored-by: Tom Atkins <[email protected]> Co-authored-by: Charl Best <[email protected]> Co-authored-by: David Kizivat <[email protected]> Co-authored-by: David Kizivat <[email protected]> Co-authored-by: Jumpei Ogawa <[email protected]> Co-authored-by: Toon van Ramshorst <[email protected]> Co-authored-by: Evgenii Neumerzhitckii <[email protected]> Co-authored-by: Gary Fox <[email protected]> Co-authored-by: Evan Unit Lim <[email protected]> Co-authored-by: Louis Deconinck <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: elim64 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keybits - Cloudflare should spin up staging URL here