Dynamic menu & footer

[LouisDeconinck]

Added two constants containing the menu items & footer links. This reduces duplication for the menu and allows for easier editing. It could also be possible to add this to the config.ts file if that is preferred. Fixes #124

Summary by CodeRabbit

• New Features
  • Improved navigation menu and footer links rendering for a more dynamic user interface.
  • Enhanced user experience with the addition of conditional icons for menu items.
• Refactor
  • Streamlined code structure by replacing hardcoded links with dynamic arrays for easier maintenance.

[coderabbitai]

Walkthrough

The changes involve restructuring the navigation menu and footer links in the +layout.svelte file to utilize dynamic arrays for rendering. This replaces the previous hardcoded links with a more maintainable approach, enhancing the flexibility and readability of the code.

Changes

Files	Change Summary
src/routes/(marketing)/...	Refactored navigation menu and footer links to use dynamic arrays for rendering.

Assessment against linked issues

Objective	Addressed	Explanation
Easy menu editing (#124)	✅

Poem

In fields of code, I hop with glee,
Menus now dance, so wild and free!
Links are gathered, neat as can be,
A rabbit's joy, oh can't you see?
With every click, the world feels bright,
Dynamic dreams take joyful flight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fd7a963 and 926a24a.

Files selected for processing (1)

• src/routes/(marketing)/+layout.svelte (4 hunks)

Additional comments not posted (5)

src/routes/(marketing)/+layout.svelte (5)

5-19: LGTM!

The menuItems array is well-structured and improves maintainability by consolidating menu items into a single location.

The code changes are approved.

---

21-30: LGTM!

The footerLinks array is well-structured and improves maintainability by consolidating footer links into a single location.

The code changes are approved.

---

39-59: LGTM!

The navigation menu rendering using a loop and conditional rendering for icons improves flexibility and readability of the code.

The code changes are approved.

---

85-105: LGTM!

The dropdown menu rendering for mobile view using a loop and conditional rendering for icons improves flexibility and readability of the code.

The code changes are approved.

---

124-126: LGTM!

The footer links rendering using a loop improves flexibility and readability of the code.

The code changes are approved.

[LouisDeconinck]

Just noticed that this approach will not work if the SVG icon consists out of multiple paths.

[scosman]

Hey @LouisDeconinck thanks for the PRs, but take a look my comments on your issues yesterday, like here: #124 (comment)

We don't want to make CMSaasStarter too much like a framework where you're learning custom things that only work in a specific framework. It should be as close to standard Svelte+tailwind as possible. The goal is to be a template with good Svelte+tailwind implementation, you fork, and then fit to your needs. We expect everyone will need to customize it a bit before shipping, and that's okay.

Aka:

• We don't need options to disable things, if you can just delete them instead.
• We don't need data structures to generate html. Want to change it? Just change it! I expect people will change things like the header a lot, and custom data structures will be harder to customize than just plain old raw svelte/html/css

Changes like #129 and #126 look good though!