Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo SDK 33 - Change the dependency #8

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Conversation

YoshiYo
Copy link

@YoshiYo YoshiYo commented Jun 7, 2019

Hi @Cretezy,

The new expo SDK 33 is released.
I would like to do several changes on your package which don't need anymore the entire expo dependency.
https://docs.expo.io/versions/latest/sdk/securestore/

What do you think about it ?
Maybe it will be a major release.

@YoshiYo YoshiYo changed the title Expo SDK 33 - Change with the dependencie Expo SDK 33 - Change the dependency Jun 7, 2019
@leviathanbeak
Copy link

@Cretezy will this be merged soon ?

@YoshiYo
Copy link
Author

YoshiYo commented Jun 18, 2019

@leviathan88
For the moment, you can use directly the fork in your package.json :

"redux-persist-expo-securestore": "https://github.com/YoshiYo/redux-persist-expo-securestore.git",

If the merge is too long, I will publish a new repository to update this one.
Tell me directly on my fork if there is a problem with this version. On my side, I don't have the expo warning anymore.

@leviathanbeak
Copy link

thanks @YoshiYo
let's wait a little bit more and then check it out

@Cretezy
Copy link
Owner

Cretezy commented Jun 19, 2019

Hi, sorry for the delay. Merging!

@Cretezy Cretezy added the enhancement New feature or request label Jun 19, 2019
@Cretezy Cretezy self-assigned this Jun 19, 2019
@Cretezy Cretezy merged commit f74cf3f into Cretezy:master Jun 19, 2019
@Cretezy
Copy link
Owner

Cretezy commented Jun 19, 2019

Just published v2.0.0 with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants