Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.9 #781

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Drop python 3.9 #781

merged 2 commits into from
Jan 24, 2025

Conversation

al-rigazzi
Copy link
Collaborator

This PR drops support for Python 3.9

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (d7d979e) to head (c13da53).
Report is 18 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #781      +/-   ##
===========================================
- Coverage    83.91%   81.62%   -2.29%     
===========================================
  Files           83       84       +1     
  Lines         6284     7009     +725     
===========================================
+ Hits          5273     5721     +448     
- Misses        1011     1288     +277     
Files with missing lines Coverage Δ
smartsim/__init__.py 100.00% <ø> (ø)

... and 47 files with indirect coverage changes

Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for catching the vestigial Summit doc page

@al-rigazzi al-rigazzi merged commit a54c3b3 into CrayLabs:develop Jan 24, 2025
19 checks passed
@al-rigazzi al-rigazzi deleted the drop-py39 branch January 24, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants