Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Slurm Launcher #741

Open
wants to merge 8 commits into
base: v1.0
Choose a base branch
from

Cancels are called concurrently

ba86cca
Select commit
Loading
Failed to load commit list.
Open

Updated Slurm Launcher #741

Cancels are called concurrently
ba86cca
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 29, 2024 in 1s

59.42% (target 0.00%)

View this Pull Request on Codecov

59.42% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.0@879b96e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/launcher/launcher.py 40.00% 3 Missing ⚠️
smartsim/entity/dbnode.py 66.66% 1 Missing ⚠️
smartsim/launchable/mpmd_job.py 0.00% 1 Missing ⚠️
smartsim/launchable/mpmd_pair.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.0     #741   +/-   ##
=======================================
  Coverage        ?   59.42%           
=======================================
  Files           ?      142           
  Lines           ?     9146           
  Branches        ?        0           
=======================================
  Hits            ?     5435           
  Misses          ?     3711           
  Partials        ?        0           
Files with missing lines Coverage Δ
smartsim/_core/launcher_/shell/shell_launcher.py 95.06% <ø> (ø)
smartsim/_core/utils/helpers.py 56.42% <100.00%> (ø)
smartsim/settings/arguments/launch/local.py 87.50% <100.00%> (ø)
smartsim/settings/arguments/launch/mpi.py 95.34% <100.00%> (ø)
smartsim/entity/dbnode.py 36.29% <66.66%> (ø)
smartsim/launchable/mpmd_job.py 87.75% <0.00%> (ø)
smartsim/launchable/mpmd_pair.py 80.00% <0.00%> (ø)
smartsim/_core/launcher/launcher.py 32.07% <40.00%> (ø)