Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests into groups for parallel execution in CI/CD runners #417

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

billschereriii
Copy link
Contributor

Split tests into groups for parallel execution in CI/CD runners
Remove some unused import statements

@billschereriii billschereriii added area: test Issues related to the test suite area: CI/CD Issues related to continuous integration and deployment labels Nov 13, 2023
@billschereriii billschereriii self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #417 (969ecc5) into develop (96765d9) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #417      +/-   ##
===========================================
+ Coverage    89.60%   89.65%   +0.05%     
===========================================
  Files           59       59              
  Lines         3617     3617              
===========================================
+ Hits          3241     3243       +2     
+ Misses         376      374       -2     

see 1 file with indirect coverage changes

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the divide-and-conquer approach. Nevertheless, the probability of hitting the pre-existing issue with Codecov is multiplied by a factor of ~3, thus I'd suggest we decide whether we are going to mark as passed the action even if codecov failed and, if that's the case, we do it as part of this PR.

@billschereriii
Copy link
Contributor Author

Looks like all the tests ran in between 9 to 18 minutes, btw

@billschereriii
Copy link
Contributor Author

Note: subdirectories full_wlm and on_wlm are intentionally skipped for CI/CD as we aren't running on HPC systems for these tests

@ankona
Copy link
Contributor

ankona commented Nov 14, 2023

Per @al-rigazzi comment about codecov... Do we want to do a minor rearrange of the build to avoid 3x the uploads? Perhaps we could:

  1. run independent test step
  2. store each codecov report as an artifact in a test step
  3. split code coverage upload to run into step successor of (1)
  4. retrieve all artifacts and upload only one time

The key difference in my head is to pull all artifacts instead of look for ./coverage.xml (and to figure out how to make the step depend on each matrix-based step).

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving & assuming you'll want to split out anything about rearranging to upload codecov results fewer times into a new ticket.

runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
subset: [backends, slow_tests, group_a, group_b]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the opaque group names, this is simple & effective. LGTM as the first step toward test domination!

@billschereriii billschereriii merged commit 15ba145 into CrayLabs:develop Nov 14, 2023
26 checks passed
@billschereriii billschereriii deleted the splittests branch November 14, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment area: test Issues related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants