Cease and desist destructive tendencies #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm hitting a problem when restarting nexus, where the `registry` suddenly changes blobstore and repos vanish. The problem is that `nexus-setup.sh` runs as an `ExecPostStart` script on the systemd service, and when it runs it has two destructive options. These destructive options make it impossible to restart the nexus service without harming an existing registry. For example, in Fawkes we create a registry in the fawkes blobstore. Restarting nexus causes that registry to be recreated again under the default blobstore, this ends up breaking image pulls. Signed-off-by: Russell Bunch <[email protected]>
rustydb
added a commit
to Cray-HPE/metal-provision
that referenced
this pull request
Oct 17, 2023
When uploading docker images, also ensure the registry is created. This needs to be merged before Cray-HPE/metal-nexus#24
4 tasks
heemstra
approved these changes
Oct 17, 2023
github-actions bot
pushed a commit
to Cray-HPE/metal-provision
that referenced
this pull request
Oct 17, 2023
When uploading docker images, also ensure the registry is created. This needs to be merged before Cray-HPE/metal-nexus#24 (cherry picked from commit 07ef993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
I'm hitting a problem when restarting nexus, where the
registrysuddenly changes blobstore and repos vanish.The problem is that
nexus-setup.shruns as anExecPostStartscript on the systemd service, and when it runs it has two destructive options.These destructive options make it impossible to restart the nexus service without harming an existing registry. For example, in Fawkes we create a registry in the fawkes blobstore. Restarting nexus causes that registry to be recreated again under the default blobstore, this ends up breaking image pulls.
Prerequisites
Idempotency
Risks and Mitigations