Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stable Builds #39

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix Stable Builds #39

merged 1 commit into from
Mar 1, 2023

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Feb 28, 2023

Summary and Scope

  • Fixes: Stable builds

Issue Type

  • Bugfix Pull Request
  • Docs Pull Request
  • RFE Pull Request

Stable builds key off of IS_STABLE to resolve which image to pull into the RPM. The IS_STABLE env. var. was removed in a previous PR.

This adds IS_STABLE back in to allow stable builds to work again.

See make rpm step output from this build: https://jenkins.algol60.net/blue/organizations/jenkins/Cray-HPE%2Fmetal-basecamp/detail/v1.2.5/2/pipeline/

[2023-02-28T22:15:53.971Z] + echo bucket: csm-docker/unstable tag: 1.2.5 current_branch: v1.2.5
[2023-02-28T22:15:53.971Z] bucket: csm-docker/unstable tag: 1.2.5 current_branch: v1.2.5
[2023-02-28T22:15:53.971Z] + timeout 15m sh -c 'until skopeo inspect docker://artifactory.algol60.net/csm-docker/unstable/metal-basecamp:1.2.5; do sleep 10; done'
[2023-02-28T22:15:54.228Z] time="2023-02-28T22:15:54Z" level=fatal msg="Error parsing image name \"docker://artifactory.algol60.net/csm-docker/unstable/metal-basecamp:1.2.5\": Error reading manifest 1.2.5 in artifactory.algol60.net/csm-docker/unstable/metal-basecamp: manifest unknown: The named manifest is not known to the registry."

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (if yes, please include results or a description of the test)
  • I tested this on a vshasta system (if yes, please include results or a description of the test)

Idempotency

Risks and Mitigations

@rustydb rustydb requested a review from a team as a code owner February 28, 2023 22:27
Stable builds key off of `IS_STABLE` to resolve which image to pull into
the RPM. The `IS_STABLE` env. var. was removed in a previous PR.

This adds `IS_STABLE` back in to allow stable builds to work again.
@rustydb rustydb merged commit 0a278fc into main Mar 1, 2023
@rustydb rustydb deleted the fix-stable-builds branch March 1, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants