Update storybook to the latest version #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles affects: @crave/farmblocks-alert, @crave/farmblocks-amount-selectors, @crave/farmblocks-button, @crave/farmblocks-card, @crave/farmblocks-carousel, @crave/farmblocks-dropdown, @crave/farmblocks-empty-state, @crave/farmblocks-filter-popover, @crave/farmblocks-footer, @crave/farmblocks-form-wrapper, @crave/farmblocks-hoc-disabled-tooltip, @crave/farmblocks-hoc-input, @crave/farmblocks-hoc-validation-messages, @crave/farmblocks-hoc-withtooltip, @crave/farmblocks-image, @crave/farmblocks-input-checkbox, @crave/farmblocks-input-currency, @crave/farmblocks-input-radio, @crave/farmblocks-input-select, @crave/farmblocks-input-text, @crave/farmblocks-label, @crave/farmblocks-link, @crave/farmblocks-map-balloon, @crave/farmblocks-more-info, @crave/farmblocks-popover, @crave/farmblocks-dev-scaffold, @crave/farmblocks-search-field, @crave/farmblocks-stepper, @crave/farmblocks-table, @crave/farmblocks-tags, @crave/farmblocks-text, @crave/farmblocks-tooltip Replaced by the global decorator withInfo to the same effect
fgameiro
changed the title
alcferreira
reviewed
Dec 27, 2018
| transform: rotate(5deg); | ||
| `; | ||
|
|
||
| const ExtendedAlert = props => <StyledAlert {...props} />; |
There was a problem hiding this comment.
Do know why the previous version won't work? I wonder if this is the best approach to handle this, because the styled(Alert) should produce a valid component 🤔
There was a problem hiding this comment.
Yeah, I found this to be strange too.
Actually this is just a workaround to avoid this warning:
According to this (storybookjs/storybook#4817) it seems that storybook can't access the components' propTypes through the styled wrapper, which raises the warning.
|
Time spent on
Can we do something to improve that? Update: We may want to follow up this issue storybookjs/storybook#4996 |
alcferreira
reviewed
Dec 27, 2018
fgameiro
changed the title
affects: @crave/farmblocks-alert, @crave/farmblocks-amount-selectors, @crave/farmblocks-button, @crave/farmblocks-card, @crave/farmblocks-carousel, @crave/farmblocks-dropdown, @crave/farmblocks-empty-state, @crave/farmblocks-filter-popover, @crave/farmblocks-footer, @crave/farmblocks-form-wrapper, @crave/farmblocks-hoc-disabled-tooltip, @crave/farmblocks-hoc-input, @crave/farmblocks-hoc-validation-messages, @crave/farmblocks-hoc-withtooltip, @crave/farmblocks-image, @crave/farmblocks-input-checkbox, @crave/farmblocks-input-currency, @crave/farmblocks-input-radio, @crave/farmblocks-input-select, @crave/farmblocks-input-text, @crave/farmblocks-link, @crave/farmblocks-map-balloon, @crave/farmblocks-more-info, @crave/farmblocks-popover, @crave/farmblocks-search-field, @crave/farmblocks-stepper, @crave/farmblocks-table, @crave/farmblocks-tags, @crave/farmblocks-text, @crave/farmblocks-tooltip
affects: @crave/farmblocks-map-balloon, @crave/farmblocks-popover, @crave/farmblocks-search-field
…onents in stories affects: @crave/farmblocks-alert, @crave/farmblocks-dropdown, @crave/farmblocks-input-select, @crave/farmblocks-map-balloon, @crave/farmblocks-search-field
We used to mock the withInfo decorator to prevent snapshots from containing css and html from 'withInfo' addon, but this doesn't work anymore. So we are now preventing the decorator to be added if we are in a test environment.
… config rules affects: @crave/farmblocks-alert, @crave/farmblocks-amount-selectors, @crave/farmblocks-button, @crave/farmblocks-card, @crave/farmblocks-carousel, @crave/farmblocks-dropdown, @crave/farmblocks-empty-state, @crave/farmblocks-filter-popover, @crave/farmblocks-footer, @crave/farmblocks-form-wrapper, @crave/farmblocks-hoc-disabled-tooltip, @crave/farmblocks-hoc-input, @crave/farmblocks-hoc-validation-messages, @crave/farmblocks-hoc-withtooltip, @crave/farmblocks-image, @crave/farmblocks-input-checkbox, @crave/farmblocks-input-currency, @crave/farmblocks-input-radio, @crave/farmblocks-input-select, @crave/farmblocks-input-text, @crave/farmblocks-label, @crave/farmblocks-link, @crave/farmblocks-map-balloon, @crave/farmblocks-more-info, @crave/farmblocks-popover, @crave/farmblocks-dev-scaffold, @crave/farmblocks-search-field, @crave/farmblocks-stepper, @crave/farmblocks-table, @crave/farmblocks-tags, @crave/farmblocks-text, @crave/farmblocks-theme, @crave/farmblocks-tooltip As we use babel to build each package independently, we must allow them to access our babel config file located at the root directory of Farmblocks. This commit adds the '--root-mode upward' flag to each build command to allow this.
…pdated build command affects: @crave/farmblocks-dev-scaffold
fgameiro
changed the title
affects: @crave/farmblocks-card
|
@alcferreira please update your local branch :) I have just rebased it fixing the cardTypes exports |
affects: @crave/farmblocks-dev-scaffold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issues
Code review checklist
Reviewer 1
Reviewer 2