Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4:3 aspect ratio is broken on ScreenMusicSelect #14

Closed
FishamanP opened this issue Dec 2, 2022 · 3 comments
Closed

4:3 aspect ratio is broken on ScreenMusicSelect #14

FishamanP opened this issue Dec 2, 2022 · 3 comments
Assignees
@CrashCringle12

Comments

@FishamanP
Copy link

As the title says, should be fairly obvious just from testing. Sorry for no screenshots right now, I don't have much spare time.
@CrashCringle12
Copy link
Owner

Ah yeah. All good, thanks for letting me know.

@CrashCringle12 CrashCringle12 self-assigned this Dec 22, 2022
@CrashCringle12
Copy link
Owner

This PR (#15) from @quietly-turning fixes the issue as long as Groovestats are not enabled. Working to get a commit out to fix the screen while Groovestats is enabled.

CrashCringle12 added a commit that referenced this issue Dec 22, 2022
@CrashCringle12
Fix PaneDisplay when Groovestats is enabled
d5022ea 
The issue #14 noted ScreenSelectMusic was broken in 4:3. The PR #15 fixed the issue; however, it broke PaneDisplay when Groovestats is enabled (It was already broken most likely in 4:3, but it was now broken across board). This should fix the display across the board.

Next commit might provide some parity with other aspect ratios if I get to it as I'm notcing some things are a bit off.
@quietly-turning
Copy link

quietly-turning commented Dec 22, 2022 •
edited
Loading

as long as Groovestats are not enabled

whoops

CrashCringle12 added a commit that referenced this issue Dec 23, 2022
@CrashCringle12
Tidied up ScreenSelectMusic for 4:3 (at least in ITG mode)
305fd7c 
RE: #14
CrashCringle12 added a commit that referenced this issue Dec 23, 2022
@CrashCringle12
Last tidyings for 4:3 while ChartParsing information is showing RE: #14
ee3aa66
CrashCringle12 added a commit that referenced this issue Dec 23, 2022
@CrashCringle12
Whoops, this wasn't supposed to be changed RE: #14
e0c8051 
alright taking a break
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Tidyings for 4:3 while ChartParsing information is showing RE: #14
cd7bfd4 
(cherry picked from commit ee3aa66)

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/DensityGraph.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/StepArtist-Classic.lua
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Tidied up ScreenSelectMusic for 4:3 (at least in ITG mode)
02b1634 
RE: #14
(cherry picked from commit 305fd7c)

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PaneDisplay.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/Cursor-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/StepArtist-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/SongDescription/SongDescription.lua
#	BGAnimations/ScreenSelectMusic overlay/StepsDisplayList/Grid-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/banner.lua
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Tidied up ScreenSelectMusic for 4:3 (at least in ITG mode)
08dc819 
RE: #14
(cherry picked from commit 305fd7c)

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PaneDisplay.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/Cursor-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/StepArtist-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/SongDescription/SongDescription.lua
#	BGAnimations/ScreenSelectMusic overlay/StepsDisplayList/Grid-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/banner.lua
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Last tidyings for 4:3 while ChartParsing information is showing RE: #14
87dd949 
Commit tweaked to align with upstream

(cherry picked from commit ee3aa66)

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/DensityGraph.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/StepArtist-Classic.lua
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Tidied up ScreenSelectMusic for 4:3 (at least in ITG mode)
ba8e8d8 
RE: #14
(cherry picked from commit 305fd7c)

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PaneDisplay.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/Cursor-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/StepArtist-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/SongDescription/SongDescription.lua
#	BGAnimations/ScreenSelectMusic overlay/StepsDisplayList/Grid-ITG.lua
#	BGAnimations/ScreenSelectMusic overlay/banner.lua
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Last tidyings for 4:3 while ChartParsing information is showing RE: #14
36de026 
Commit tweaked to align with upstream

(cherry picked from commit ee3aa66)

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/DensityGraph.lua
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/StepArtist-Classic.lua

# Conflicts:
#	BGAnimations/ScreenSelectMusic overlay/PerPlayer/DensityGraph.lua
CrashCringle12 added a commit that referenced this issue Dec 28, 2022
@CrashCringle12
Tidied up Music select screens for 4:3
672ddd3 
(cherry picked from commit 305fd7c
RE: #14)
CrashCringle12 pushed a commit that referenced this issue Mar 31, 2023
@zarzob @natano
Don't send player-leaderboards request when there is no chart hash (#14)
25c2bbc 
Sending the request without hash causes an error response from the GS
API resulting in the integration getting disabled.

fixes Simply-Love#407

Co-authored-by: Martin Natano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CrashCringle12 CrashCringle12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quietly-turning @FishamanP @CrashCringle12