Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for creating and joining voice channels #104

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

Filip3314
Copy link
Contributor

While testing my bot, I ran into issues because some of its functionality relies on joining/leaving voice channels or checking the voice state of users. To remedy this, I've implemented the FakeVoiceChannel and FakeVoiceClient classes, in addition to creating a callback for edit_member and expanded the create_channel method to cover voice channels. I've included some tests for the new feature.

Please let me know if you think there's anything missing or incorrect in my PR. Thanks!

@Sergeileduc
Copy link
Collaborator

Sounds good (I didn't have time to checkout out and test, but it sounds good)

Just a typo.

also, if you could rebase, in order to have less commits (and make a new PR when it's done) ?
it's not super important, if you can't, it's okay, don't worry.

@Filip3314
Copy link
Contributor Author

Hey, thanks for taking a look at the PR. I can rebase and make a new one, no problem.
About the typo, could you tell me where it is so I could fix it?

@Filip3314 Filip3314 closed this Apr 20, 2023
@Sergeileduc
Copy link
Collaborator

ho you don't see my review ? didn't know.

yeah it's in tests/test_permissions.py line 34

administrator is misspelled

@Sergeileduc
Copy link
Collaborator

Sergeileduc commented Apr 20, 2023

ho you don't see my review ? didn't know.

yeah it's in tests/test_permissions.py line 34

administrator is misspelled

@Filip3314

Voice channels are created in the config now. Bots can join and leave
voice channels, and members can be moved into/out of voice channels.
@Filip3314
Copy link
Contributor Author

Okay, rebased and squashed all the commits into one. Fixed the typo as well. Let me know if there's anything else I need to do!

@Sergeileduc Sergeileduc merged commit a78c572 into CraftSpider:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants