Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 94 - Solution to Issue #94 #95

Merged
merged 3 commits into from
Feb 22, 2016
Merged

Conversation

dash-
Copy link
Contributor

@dash- dash- commented Feb 22, 2016

Reworked ResultSet.getObjectIter() method. Generally refactored it, but also added logic to return null for integers rather than zero, which is detected via getObjectSync().

Also includes style fixes (tabs to spaces) for two files (lib/databasemetadata.js, lib/statement.js).

Basic and others added 3 commits February 18, 2016 15:30
…ning null rather than zero for null integers
Merge CraZySacX/node-jdbc back into dash-/node-jdbc
@dash-
Copy link
Contributor Author

dash- commented Feb 22, 2016

So this failed because two test runs had an ECONNRESET during the initial npm install. So it doesn't seem related to any of the changes. I'd like to tell travis.ci to "try again" but I'm not quite sure how yet.

@dash- dash- closed this Feb 22, 2016
@dash- dash- reopened this Feb 22, 2016
@dash-
Copy link
Contributor Author

dash- commented Feb 22, 2016

Closed and re-opened to trigger Travis.ci rebuild.

@dash-
Copy link
Contributor Author

dash- commented Feb 22, 2016

Failed again due to network hangup (during npm install pre-step). On just one test this time (and a different test than the previous two). Between the two, all tests have passed. Closing and re-opening again to re-trigger travis.ci again.

@dash- dash- closed this Feb 22, 2016
@dash- dash- reopened this Feb 22, 2016
@CraZySacX
Copy link
Owner

Looks like close open is the easiest way to restart the build on travis. You can also try git commit --allow-empty -m "Trigger" per http://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit, but I haven't tested that.

CraZySacX added a commit that referenced this pull request Feb 22, 2016
Feature 94 - Solution to Issue #94
@CraZySacX CraZySacX merged commit b8cae64 into CraZySacX:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants