This repository has been archived by the owner on Oct 25, 2019. It is now read-only.
Error on trailing directives and broken pragmas. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
1 similar comment
|
ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #26 and #27. In both cases now, groundskeeper will error out on a broken file. This greatly reduces the chances of an unexpected output or runtime error as described in those two bugs.
I revved it up to 0.2.00 because the error behavior is distinct from the 0.1.xx behavior, and while it's not an API change, this will mean people are opting in to this new behavior (although, one would hope they'd like to know if groundskeeper is outputting unintended code!)