Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy additional resources #206

Closed
moqmar opened this issue Mar 8, 2018 · 3 comments
Closed

Copy additional resources #206

moqmar opened this issue Mar 8, 2018 · 3 comments

Comments

@moqmar
Copy link
Contributor

moqmar commented Mar 8, 2018

Currently it seems like there's no way to include e.g. an image from the source folder, or at least I didn't find it yet. There would be two possibilities:

  • Adding a folder, e.g. "assets", which is copied to the output directory, Maybe make this configurable like includeAssets: ["assets", "images", "..."]
  • Copy all files from folders explicitly mentioned in the include configuration option
  • Copy all files except for special files like couscous.yml and files/folders in exclude (we'd need files there, not just folders)
@mnapoli
Copy link
Member

mnapoli commented Mar 9, 2018

@moqmar
Copy link
Contributor Author

moqmar commented Mar 9, 2018

Ah, I see, I tried it with an SVG image. It would be great though to add some kind of configurability to that step, or at least some documentation on what files are copied. SVG is definitely missing in my opinion.

@mnapoli
Copy link
Member

mnapoli commented Mar 9, 2018

Feel free to send a pull request to modify this line: https://github.com/CouscousPHP/Couscous/blob/master/src/Module/Core/Step/AddImages.php#L27

mnapoli added a commit that referenced this issue Jul 12, 2019
Fix #206 Add SVG support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants