This repository has been archived by the owner on May 23, 2023. It is now read-only.
Fix for lane transition maneuvers #3421 #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitted `turnDiameter` x offsets from the first quarter turn. Appears to now generate the intended course for 180-90-90 and 90-90-180 maneuvers.
…mpt2 Fix for lane transition maneuvers #3421
|
Gotta find a good way to increment the version number in modDesc.xml ... |
pvaiko
added a commit
that referenced
this pull request
Mar 24, 2019
|
@pvaiko There's this |
|
Will take a look, thanks. Don't really care if it messes up the current numbering, we need something automatic. |
|
@GeorgeEarslight and thanks for the fix, from now on you are the official Courseplay turn maneuver guru :) |
|
@pvaiko no problem, nothing more relaxing than some recreational code reviewing after a day of code composing. I'll re-install Octave so I can debug maneuver generation outside the game. |
|
Cool. I used Geogebra to set up the math for the headland turns |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitted
turnDiameterx offsets from the first quarter turn.Appears to now generate the intended course for 180-90-90 and 90-90-180 maneuvers.