Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Beta Branch #3446

Closed
pvaiko opened this issue Mar 21, 2019 · 5 comments
Closed

Beta Branch #3446

pvaiko opened this issue Mar 21, 2019 · 5 comments
Assignees

Comments

@pvaiko
Copy link
Contributor

pvaiko commented Mar 21, 2019

When implementing the pull back for the combines (see #3282 (comment)) I had to do more refactoring than I'm comfortable with to push on master. I think it is quite ok but as usual, I did not have time to test everything. So for those who want to try, here's the beta branch:

https://github.com/Courseplay/courseplay/tree/beta

I also threw in #3379 to stop the engine automatically after 30 seconds because I fear there'll be some edge cases where CP won't start the engine when it needs to.

Please report any problems you find with the beta in this issue.

@pvaiko pvaiko self-assigned this Mar 21, 2019
@pvaiko pvaiko pinned this issue Mar 21, 2019
@RUGhost
Copy link

RUGhost commented Mar 22, 2019

First, In case of first headland if combine harvester is full of grain it just stand there and unloader needs to drive through fruit to unload the harvester. (Suggestion_1: it should make a pocket before fill up sothat unloader get space beside the harvester )
second, sometimes combine harvester start automatically (if it stoped for saving fuel) but maximum time it won't start.
(suggestions_2: if harvester is 90 or 95% full (which amount you like) before entering next row then he call unloader.)

@pvaiko
Copy link
Contributor Author

pvaiko commented Mar 22, 2019

Thanks for testing. The reason I linked a specific comment from #3282 is that I implemented that specific idea only. I have not implemented all the others yet, including both of your suggestions.

second, sometimes combine harvester start automatically (if it stopped for saving fuel) but maximum time it won't start

Not sure what are you trying to say here.

@RUGhost
Copy link

RUGhost commented Mar 22, 2019

Sometimes combine harvester wait for a unloader and stop its engine. After I unload him, he doesn't start engine automatically. To make it working I need to stop the cp driver then I need to activate "drive course".

@RUGhost
Copy link

RUGhost commented Mar 22, 2019

And thanks for implementing pull back to the combine. Its working nice.

@pvaiko pvaiko unpinned this issue Mar 23, 2019
@pvaiko
Copy link
Contributor Author

pvaiko commented Mar 23, 2019

Merged to master, closing

@pvaiko pvaiko closed this as completed Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants