Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update MUI to v5 #4363

Closed
wants to merge 3 commits into from
Closed

[WIP] Update MUI to v5 #4363

wants to merge 3 commits into from

Conversation

ekowidianto
Copy link
Member

@ekowidianto ekowidianto commented Feb 14, 2022

Staged updates:

There are 2 versions each for v3 and v4 updates (rebased and non-rebased branches). For v5 update, we will only work on the rebased branch.

Closes #2438

margin-bottom: 1em;
margin-top: 1em;
margin-bottom: 1em !important;
margin-top: 1em !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

@@ -68,6 +67,6 @@
}

.submitButton {
margin-bottom: 1em;
margin-top: 1em;
margin-bottom: 1em !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

margin-right: 1em;
margin-top: 0.5em;
cursor: pointer !important;
margin-right: 1em !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

cursor: pointer;
margin-right: 1em;
margin-top: 0.5em;
cursor: pointer !important;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

@ekowidianto ekowidianto force-pushed the eko/upgrade-mui branch 8 times, most recently from 76c3a06 to 4221da1 Compare February 15, 2022 12:57
@ekowidianto ekowidianto changed the title Update MUI to v5 [WIP] Update MUI to v5 Feb 15, 2022
@ekowidianto ekowidianto force-pushed the eko/upgrade-mui branch 13 times, most recently from bbd8e5c to 22e7bac Compare February 21, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to material-ui v5
1 participant