Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2841

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Fixes #2841

merged 9 commits into from
Dec 13, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Dec 13, 2024 •
edited
Loading

  • Check if rollback is needed on revision bump
  • Get transaction by batch when parsing mempoool
  • Set BACKEND_RAW_TRANSACTIONS_CACHE_SIZE to 1000
  • Fix RPC call duration logging
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft December 13, 2024 13:14
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 13, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/api/api_server.py Outdated
@@ -363,6 +363,9 @@
except Exception as e:
capture_exception(e)
logger.error("Error in API: %s", e)
import traceback

Check warning

Code scanning / pylint

Import outside toplevel (traceback). Warning

Import outside toplevel (traceback).
@ouziel-slama ouziel-slama marked this pull request as ready for review December 13, 2024 16:40
@ouziel-slama ouziel-slama merged commit d0b2cdd into develop Dec 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel