Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Cleanup + Enable CosmWasm 1.2 feature #626

Merged
merged 16 commits into from
Apr 8, 2023
Merged

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Mar 29, 2023

Fixes

  • Added cosmwasm_1_2 type to whitelist
  • CometBFT from Skip
  • Fix ictest: TestBasicJunoStart
  • GlobalFee Bypass: MsgTimeout & MsgTimeoutOnClose (Co author @giansalex. Will credit in the release notes)

Cleanup

  • Cancel ictest on new commit if still running in previous
  • Moves GetChainsDenomToken to a single function definition
  • Bump protobuf version

@Reecepbcups Reecepbcups marked this pull request as ready for review March 29, 2023 18:38
@Reecepbcups Reecepbcups changed the title [v14] Cleanup Branch [v14] Cleanup + Enable CosmWasm 1.2 feature Mar 30, 2023
Copy link
Contributor

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reecepbcups Reecepbcups changed the title [v14] Cleanup + Enable CosmWasm 1.2 feature [v14] Cleanup + Enable CosmWasm 1.2 feature | State Breaking Mar 31, 2023
@Reecepbcups Reecepbcups changed the title [v14] Cleanup + Enable CosmWasm 1.2 feature | State Breaking [v14] Cleanup + Enable CosmWasm 1.2 feature Apr 1, 2023
@Reecepbcups Reecepbcups marked this pull request as draft April 1, 2023 01:58
@Reecepbcups
Copy link
Contributor Author

Will discuss this Monday, but we can't have 2 upgrade handlers set. only the last one applies even though the upgradeKeeper accepts a map of upgrade names

I wanted to do it safe, but since it is non-state breaking, we can just ask vals to halt at some height, then apply.


Reason:

If v14.Upgrade is last in the upgrade array, then it applies even if we call another upgrades name (univ14part2 in this case)

If univ14part2 is last, then interchain upgrade test fails because it was doing v13 -> this upgrade, even though we tell it "v14"

@faddat
Copy link
Contributor

faddat commented Apr 3, 2023

definitely would like to go over this on the call.

Thanks for this @Reecepbcups

@Reecepbcups
Copy link
Contributor Author

Reecepbcups commented Apr 3, 2023

Tagged off this as alpha.2 after CI completed. Ran on my Uni val just fine, distributed to uni vals

@Reecepbcups Reecepbcups marked this pull request as ready for review April 4, 2023 05:59
@Reecepbcups Reecepbcups enabled auto-merge (squash) April 4, 2023 06:00
@Reecepbcups Reecepbcups added the review me Review me for merge label Apr 6, 2023
@faddat
Copy link
Contributor

faddat commented Apr 8, 2023

good stuff

@Reecepbcups Reecepbcups merged commit cd0e46c into main Apr 8, 2023
@Reecepbcups Reecepbcups deleted the reece/v14-cleanup branch April 8, 2023 14:05
@Reecepbcups Reecepbcups removed the review me Review me for merge label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants