-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14] Cleanup + Enable CosmWasm 1.2 feature #626
Conversation
…past CI until now??" This reverts commit 0820813.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
46c7bb9
to
2ab8b83
Compare
Will discuss this Monday, but we can't have 2 upgrade handlers set. only the last one applies even though the upgradeKeeper accepts a map of upgrade names I wanted to do it safe, but since it is non-state breaking, we can just ask vals to halt at some height, then apply. Reason: If v14.Upgrade is last in the upgrade array, then it applies even if we call another upgrades name (univ14part2 in this case) If univ14part2 is last, then interchain upgrade test fails because it was doing v13 -> this upgrade, even though we tell it "v14" |
definitely would like to go over this on the call. Thanks for this @Reecepbcups |
Tagged off this as alpha.2 after CI completed. Ran on my Uni val just fine, distributed to uni vals |
good stuff |
Fixes
Cleanup