Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes PlaceholderLabel position when right-aligned - iOS 11.0 #873

Merged
merged 4 commits into from
Sep 25, 2017
Merged

Fixes PlaceholderLabel position when right-aligned - iOS 11.0 #873

merged 4 commits into from
Sep 25, 2017

Conversation

mohpor
Copy link
Contributor

@mohpor mohpor commented Sep 23, 2017

Hi,
It seems like UIKit doesn't apply transform to a view's bounds anymore, therefore, the line of code that determines placeholderLabel's position results in zero difference between the original frame and scaled down placeholderLabel's. (TextField.swift line: 569)

The solution is to use placehlderLabel's frame instead.

@daniel-jonathan daniel-jonathan self-assigned this Sep 25, 2017
@daniel-jonathan daniel-jonathan merged commit 72c9730 into CosmicMind:development Sep 25, 2017
@daniel-jonathan
Copy link
Member

Excellent, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-jonathan daniel-jonathan daniel-jonathan approved these changes

Assignees

@daniel-jonathan daniel-jonathan

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohpor @daniel-jonathan @DanielDahan