Added dialogs #1173
Merged
Added dialogs #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-jonathan
requested changes
Oct 16, 2018
Sources/iOS/DialogView.swift
Outdated
| w = min(w, size.width) | ||
| } | ||
|
|
||
| setW(titleAreaSizeThatFits(width: size.width).width) |
There was a problem hiding this comment.
Let's not use methods like setW, we should use setWidth.
Sources/iOS/DialogView.swift
Outdated
| } | ||
| } | ||
|
|
||
| private struct Constants { |
There was a problem hiding this comment.
If you use Constants to guide a components design, let's put it at the top, so when it is first looked at, we can see it right away and know the mechanical configuration.
daniel-jonathan
requested changes
Oct 16, 2018
daniel-jonathan
approved these changes
Oct 16, 2018
This was referenced Oct 16, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took from #1021, added comments, updated code style, and made themeable.
Sample app:
Button.zip