Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interactive swipe #1165

Merged
merged 6 commits into from
Sep 27, 2018
Merged

Added interactive swipe #1165

merged 6 commits into from
Sep 27, 2018

Conversation

OrkhanAlikhanov
Copy link
Contributor

@OrkhanAlikhanov OrkhanAlikhanov commented Sep 25, 2018

Sample apps to test out interactive swipe transition:

Copy link
Member

@daniel-jonathan daniel-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, only a couple aesthetic comments, as well as the flick issue. Excellent work!

Sources/iOS/BottomNavigationController.swift Show resolved Hide resolved
Sources/iOS/TabsController.swift Show resolved Hide resolved
@daniel-jonathan
Copy link
Member

@OrkhanAlikhanov All looks good. I think only the last little bug we found :)

@daniel-jonathan daniel-jonathan merged commit 0cddaeb into CosmicMind:development Sep 27, 2018
@OrkhanAlikhanov OrkhanAlikhanov changed the title [WIP] Adding interactive swipe Added interactive swipe Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants