Investigate Any Memory Leaks

[foxsin10]

This UI framework is awesome, I really like it.And I have been used it in my project since Swift 2.2.
Recently, I decided to migrate to Swift 3.0, but When I run the NavigatioanController Demo with Instruments two days ago,I found there are leaks .There are some issues with Grid.swift

[daniel-jonathan]

Nice catch. I'll investigate, and please share more if possible. Thank you :)

[foxsin10]

I'm coding with version Material 2.2.5.
The demo I downloaded is using Material 2.0.
Maybe It's been fixed in Material 2.3 .Anyway , I'm updating and then try it again.

[daniel-jonathan]

I verified the issue. I will fix this tomorrow. Thank you!

[foxsin10]

Good job!

[daniel-jonathan]

The fix is in Material 2.3.4. Thank you for bringing this to my attention :)

[foxsin10]

Appreciated your work.
Maybe there are some work left to be done. :)
see:

[daniel-jonathan]

Yes, I want to go through each part. I closed your issue as it was related to GridAxis itself. Let's reopen this issue and treat it as a general memory leak investigation :)

[foxsin10]

Sorry , forgot to check my email.
I’m kind of busy recently, maybe after I check your source code and do some investigation, now I get to turn to my work. :)

在 2016年11月11日，00:16，Daniel Dahan [email protected] 写道：

@foxsin10 https://github.com/foxsin10 So I am looking through all the code in Material and I get what seems to be a strange memory issue that I think you may be able to help with. In the Bar type objects, there is a property contentView that I have reduced down to a UIView from a View to simplify the investigation. It seems that whenever I do this bar.contentView. = value I get an issue where the getter adds a new retain. Please look at the images below.

https://cloud.githubusercontent.com/assets/9982123/20184543/dcd7fa08-a71d-11e6-89fc-bad635db62db.png
https://cloud.githubusercontent.com/assets/9982123/20184544/de5c91f4-a71d-11e6-8296-098a75792a9b.png
Do you have any ideas what is going on here?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #588 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ALF4OqdLxVX5ShArDtEcwy1YZKKAGL98ks5q80NCgaJpZM4KsKG4.

[daniel-jonathan]

No worries :) I figured it out.

[daniel-jonathan]

I am going to continue to make improvements in this area if I find any issues. For now, unless there is a specific memory leak found, there doesn't need to be an issue. Thank you for bringing this to my attention :)