-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong instance returned by fabMenuController #1016
Comments
It actually goes up and then goes down. I think the issue is that it is only looking for v = v?.parent as? TransitionController If I push a change to Thank you! |
yes I can try. Push to dev and I will let you know. |
Okay, give this commit a try: cf88010 |
This works - but I am clueless why it works now! Can you explain please. |
Basically it was skipping over one of your contained view controllers and making it nil, forcing it to search top down. This was happening because it was only looking for |
Here is a release for the update: Material 2.13.4. Thank you for sharing :) |
thank you! Good job |
In my app I have two FAB controllers both are used in total different vertical. But when I try to access fabMenuController it returns wrong instance from different vertical.
Issue comes from how the traversing work. I think it should start from current ViewController and try to find upward. From the code execution that I see it jumps to app delegate root controller and then start to traverse down. Which returns the first instance it find for FabMenuController not the FabMenuController for the vertical I am sitting in ?
The text was updated successfully, but these errors were encountered: