Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigationDrawerController?.toggleLeftView() does not work when navigationDrawer is not rootViewController #960

Closed
varijkapil13 opened this issue Nov 9, 2017 · 6 comments

Comments

@varijkapil13
Copy link

I am building navigationDrawerController with tabsController. And in the application not all view controller require the navigation drawer, there I only assign navigation drawer to the view that requires it. It works fine when the tabsController is set as window root, but when I transition to tabsController via a navigationController push method (UINavigationController or Material) from another roortViewController, example a login screen, the navigationDrawerController?.toggleLeftView() code in the menu button handler does not open the navigationDrawer. However, sliding from left opens the drawer.

AppDelegate

screen shot 2017-11-09 at 12 20 10

Login View Controller (when login is done, I want to go to the tabsController with the navigationDrawer)

screen shot 2017-11-09 at 12 22 05

Menu Button handler

screen shot 2017-11-09 at 12 23 09

@daniel-jonathan daniel-jonathan self-assigned this Nov 9, 2017
@daniel-jonathan
Copy link
Member

Hey :) Is your handleMenuButton in a view controller that is being removed once you push your new view controllers? If that is the case, then the function handler may be out of scope causing the issue. I would need to look at your project to confirm this.

@varijkapil13
Copy link
Author

Hey :) handleMenuButton is in the new view controller that is being pushed. it is in the startegyViewController that I have in the DrawerController and then in TabsController (See second screenshot). It gets fired whenever I click on the menu button, but nothing happens except the ripple effect on the button.

Unfortunately I cannot put the project on GitHub, I can email you the relevant files if you want :)

@daniel-jonathan
Copy link
Member

Yes, please email me the project at [email protected] :) It would be easier. Once I am done giving you help, I delete all materials you sent.

@varijkapil13
Copy link
Author

Thank you! Sent! :)

@daniel-jonathan
Copy link
Member

Great! I will take a look shortly :)

@OrkhanAlikhanov
Copy link
Contributor

@DanielDahan I confirm that this issue no longer persists after Material 2.13.4. It was fixed when you fix #1016 in cf88010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants