Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to forked sdk v0.38.2, with restart bugfix #66

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Conversation

ethanfrey
Copy link
Member

Closes #54

While waiting for upstream fix, use confio fork, that takes in the upstream fix to the iavl/restart issue and a few minor debugging enhancements I came across.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #66 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #66      +/-   ##
=========================================
+ Coverage   63.44%   63.5%   +0.06%     
=========================================
  Files          14      14              
  Lines        1116    1118       +2     
=========================================
+ Hits          708     710       +2     
  Misses        341     341              
  Partials       67      67
Impacted Files Coverage Δ
app/app.go 89.09% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff0a12...aaad847. Read the comment docs.

@ethanfrey ethanfrey merged commit a7e8464 into master Feb 9, 2020
@ethanfrey ethanfrey deleted the update-sdk branch February 9, 2020 12:53
loloicci pushed a commit to loloicci/wasmd that referenced this pull request Feb 8, 2024
* test: add invalid pagination key test in AllContractState

Signed-off-by: 170210 <[email protected]>

* test: add invalid pagination key test in ContractHistory

Signed-off-by: 170210 <[email protected]>

* test: add invalid pagination key test in Codes

Signed-off-by: 170210 <[email protected]>

* chore: add this PR to CHANGELOG

Signed-off-by: 170210 <[email protected]>

---------

Signed-off-by: 170210 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't restart with cosmos-sdk 0.38
2 participants