Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibc query only returns open channels #568

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

ethanfrey
Copy link
Member

Closes #556

@ethanfrey ethanfrey requested a review from alpe as a code owner July 28, 2021 08:17
@ethanfrey ethanfrey requested a review from webmaster128 July 28, 2021 08:21
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #568 (70191a7) into master (f6002fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   59.65%   59.65%           
=======================================
  Files          45       45           
  Lines        5260     5260           
=======================================
  Hits         3138     3138           
  Misses       1892     1892           
  Partials      230      230           
Impacted Files Coverage Δ
x/wasm/keeper/query_plugins.go 78.44% <100.00%> (ø)

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not very familiar with this tech

@ethanfrey
Copy link
Member Author

It's really just adding a filter to a state. If you don't see obvious typos, then it is likely good.

@ethanfrey ethanfrey merged commit c84a086 into master Jul 28, 2021
@ethanfrey ethanfrey deleted the 556-ibc-query-only-open-channels branch July 28, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IbcQuery only returns channels in Established state
2 participants