Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use errors.New to replace fmt.Errorf with no parameters #2140

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

LesCyber
Copy link
Contributor

@LesCyber LesCyber commented Mar 2, 2025

Replaced fmt.Errorf with errors.New in cases where formatting is not required. This reduces unnecessary function calls, leading to slightly improved performance and cleaner code.

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 46.10%. Comparing base (90b49fc) to head (efd5fe1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/client/cli/tx.go 0.00% 7 Missing ⚠️
x/wasm/client/cli/gov_tx.go 60.00% 2 Missing ⚠️
x/wasm/client/cli/query.go 0.00% 1 Missing ⚠️
x/wasm/keeper/wasmtesting/mock_keepers.go 0.00% 1 Missing ⚠️
x/wasm/module.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
- Coverage   46.12%   46.10%   -0.02%     
==========================================
  Files          78       78              
  Lines       10731    10731              
==========================================
- Hits         4950     4948       -2     
- Misses       5339     5340       +1     
- Partials      442      443       +1     
Files with missing lines Coverage Δ
x/wasm/types/validation.go 96.36% <100.00%> (ø)
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)
x/wasm/keeper/wasmtesting/mock_keepers.go 0.00% <0.00%> (ø)
x/wasm/module.go 0.00% <0.00%> (ø)
x/wasm/client/cli/gov_tx.go 12.29% <60.00%> (ø)
x/wasm/client/cli/tx.go 15.18% <0.00%> (ø)

... and 1 file with indirect coverage changes

@chipshort chipshort merged commit eb23128 into CosmWasm:main Mar 3, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants