chore: update ibc-go v10 to rc.3 #2139
Conversation
* Update setup_wasmd.sh * Update setup_wasmd.sh
Signed-off-by: costcould <[email protected]>
…Wasm#2133) * Update broken link README.md * Update broktn link INTEGRATION.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/ibc_eureka #2139 +/- ##
===================================================
- Coverage 46.10% 45.97% -0.14%
===================================================
Files 78 78
Lines 10731 10685 -46
===================================================
- Hits 4948 4912 -36
+ Misses 5340 5335 -5
+ Partials 443 438 -5
|
| @@ -567,7 +557,7 @@ func NewWasmApp( | |||
| appCodec, | |||
| runtime.NewKVStoreService(keys[icahosttypes.StoreKey]), | |||
| app.GetSubspace(icahosttypes.SubModuleName), | |||
| app.IBCFeeKeeper, // use ics29 fee as ics4Wrapper in middleware stack | |||
| app.IBCKeeper.ChannelKeeper, | |||
| app.IBCKeeper.ChannelKeeper, | |||
There was a problem hiding this comment.
This app.IBCKeeper.ChannelKeeper, app.IBCKeeper.ChannelKeeper, looks fishy
There was a problem hiding this comment.
It is correct here though, as there is no stack (porttypes.ICS4Wrapper), so we can just use the channelkeeper as the stack.
| }, | ||
| PacketFee: ibcfeetypes.NewPacketFee(fee, sender.String(), msg.PayPacketFeeAsync.Relayers), | ||
| } | ||
| return []sdk.Msg{msg}, nil |
There was a problem hiding this comment.
I would suggest keeping the cases here and add more specific error messages than the fallback
There was a problem hiding this comment.
Good point. Added that and tests for it too.
gjermundgaraba
changed the title
|
FYI: I just updated to the latest RC, in which there were a couple of minor changes. The "biggest" is probably callbacks getting embedded into ibc-go, so it's not a separate module in go.mod. Take a look and let me know. |
LGTM 👍 |
No description provided.