sdk 047 #1132
sdk 047 #1132
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks Jacob! I appreciate your help. It is easy to miss some changes so any help is appreciated but let's stick with official repos. We are in close contact with the IBC team, too to get any issues out of our way. Status of inter-tx is one of them. |
|
totally :). think we've got a PR into ibc-go for the ibc, as I fully agree re: official repos. Basically that replace is there so we could make progress. Next tho, concerning icad, I think that there are some questions as to how it's doing ICA, post ibc v6. There were some kinda questionable-feeling pieces of the code when I read through it. Thanks to yall at confio for your work over the years! Vuong, thx for the cleanup on these :) |
| @@ -39,11 +39,6 @@ func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) { | |||
| return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "tx counter key is required for ante builder") | |||
| } | |||
|
|
|||
| sigGasConsumer := options.SigGasConsumer | |||
x/wasm/ibctesting/chain.go
Outdated
| @@ -497,8 +497,8 @@ func (chain *TestChain) CreateTMClientHeader(chainID string, blockHeight int64, | |||
| // MakeCommit expects a signer array in the same order as the validator array. | |||
| // Thus we iterate over the ordered validator set and construct a signer array | |||
| // from the signer map in the same order. | |||
| signerArr := make([]tmtypes.PrivValidator, len(tmValSet.Validators)) | |||
| for i, v := range tmValSet.Validators { | |||
| signerArr := make([]tmtypes.PrivValidator, len(tmValSet.Validators)) //nolint:staticcheck // TODO: determine if there's really a possible nil pointer dereference | |||
There was a problem hiding this comment.
@faddat Are you going to follow up on this? Let's not add more todos in code
There was a problem hiding this comment.
ah, yeah, will be following up now :)
There was a problem hiding this comment.
PS: wdyt on this one?
Now that I'm looking at it, the TODO is def because I wasn't real sure at all.
app/app.go
Outdated
| @@ -127,9 +127,9 @@ import ( | |||
|
|
|||
| // Note: please do your research before using this in production app, this is a demo and not an officially | |||
| // supported IBC team implementation. It has no known issues, but do your own research before using it. | |||
| // intertx "github.com/cosmos/interchain-accounts/x/inter-tx" | |||
There was a problem hiding this comment.
I will keep inter-tx commented out until official supported versions are available. This is just a TODO
…prove"" This reverts commit 880282a.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing this in favour of #1136 . I would be happy to get your review |
Hi, @alpe -- here's a PR into the 47 branch you're working on.
If you'd rather not get these, please let me know.
Cheers!
-Jacob
Thus far, this PR: