-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint tests #1130
lint tests #1130
Conversation
Kudos, SonarCloud Quality Gate passed! |
Thank you for the PR! This was probably a lot of work. I would like to get some more feedback if we really want to enforce linter constraints on tests. This was sometimes a heated debate on previous projects. |
Opinion: it's important, and results in better tests. Best example for testing is errcheck. While we test, we often don't check errors, and in the long run this could lead to faulty tests. |
@Mergifyio rebase There was no other feedback. So my only concern now is that this is going to create tons of merge conflicts with |
❌ Base branch update has failed
|
There are already a lot of merge conflicts with #1149 . I appreciate your effort and energy but in order to reduce the workload while maintaining 2 active development branches, I close this now. |
The cosmos-sdk, ibc-go and gaia all fail to lint tests, leading to
inconsistencies. This PR addresses that.