Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove genesis msgs #1104

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Remove genesis msgs #1104

merged 3 commits into from
Dec 9, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Nov 22, 2022

Resolves #987

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1104 (aeecb1c) into main (ef12d4b) will decrease coverage by 2.00%.
The diff coverage is 5.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   59.54%   57.53%   -2.01%     
==========================================
  Files          54       53       -1     
  Lines        7566     7289     -277     
==========================================
- Hits         4505     4194     -311     
- Misses       2731     2800      +69     
+ Partials      330      295      -35     
Impacted Files Coverage Δ
x/wasm/client/cli/gov_tx.go 12.59% <0.00%> (-0.22%) ⬇️
x/wasm/client/cli/tx.go 11.46% <0.00%> (-11.48%) ⬇️
x/wasm/types/genesis.go 84.00% <ø> (-3.88%) ⬇️
x/wasm/types/proposal.go 50.00% <0.00%> (-2.74%) ⬇️
x/wasm/types/test_fixtures.go 82.20% <ø> (-11.41%) ⬇️
x/wasm/keeper/genesis.go 91.04% <100.00%> (+1.57%) ⬆️
x/wasm/module.go 37.90% <100.00%> (ø)
x/wasm/types/tx.go 48.27% <0.00%> (-0.50%) ⬇️

@pinosu pinosu marked this pull request as ready for review November 22, 2022 11:08
@pinosu pinosu requested a review from alpe as a code owner November 22, 2022 11:08
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the changes look good! Thanks! 🌷
Feel free to merge when the conflicts are resolved

I am 😄 and 😢 at the same time to see this gone.

@pinosu pinosu force-pushed the 987-remove_genesis_msgs branch from fb4847c to 3a786bd Compare December 9, 2022 11:55
@pinosu pinosu force-pushed the 987-remove_genesis_msgs branch from 3a786bd to aeecb1c Compare December 9, 2022 11:59
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.1% 2.1% Duplication

@pinosu pinosu merged commit f3ebd92 into main Dec 9, 2022
swelf19 added a commit to neutron-org/wasmd that referenced this pull request Apr 13, 2023
@alpe alpe deleted the 987-remove_genesis_msgs branch May 10, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove genesis messages
2 participants