Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Executors #386

Merged
merged 5 commits into from
Jun 27, 2024
Merged

feat: Executors #386

merged 5 commits into from
Jun 27, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird self-assigned this May 29, 2024
This was linked to issues May 29, 2024
Generate the Executor struct from the contract type #132
Closed
Generate implementation of the contract Executor trait on the contract Remote type #133
Closed
Generate the Executor struct from the interface trait #134
Closed
Generate implementation of the interface Exexutor trait on the trait Remote type #135
Closed
Generate implementation of the interface Executor trait on the contract Remote type #136
Closed
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.29545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.15%. Comparing base (0e69cc8) to head (00cc2ad).

Files Patch % Lines
sylvia/tests/executor.rs 93.75% 2 Missing ⚠️
sylvia/tests/remote.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   85.48%   86.15%   +0.67%     
==========================================
  Files          37       39       +2     
  Lines        2639     2789     +150     
==========================================
+ Hits         2256     2403     +147     
- Misses        383      386       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was linked to issues May 29, 2024
Create execution helpers #130
Closed
Create proxy types built from the binary message and contract address (address kept by reference), allowing to add of optional funds and reply information, building the final message to send #131
Closed
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch 2 times, most recently from 9b16355 to 4718249 Compare June 5, 2024 10:18
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch 3 times, most recently from 7a18d73 to 286b655 Compare June 18, 2024 11:15
@kulikthebird kulikthebird marked this pull request as ready for review June 18, 2024 11:27
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch from 286b655 to fb4c245 Compare June 18, 2024 11:56
@kulikthebird
Copy link
Contributor Author

According to #130 sylvia should provide reply_on method on the executor builder structure. From the sylvia point of view it's better not to duplicate the interface of SubMsg. Instead of adding reply_on() method on ExecutorBuilder, user should use build() method and then use on of the reply_* methods of SubMsg to create that strucutre.

@kulikthebird kulikthebird requested a review from jawoznia June 18, 2024 12:02
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch from 8ca1706 to b6e3d97 Compare June 19, 2024 10:50
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch from b6e3d97 to f086c11 Compare June 19, 2024 11:42
jawoznia
jawoznia reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to consider before approving

sylvia-derive/src/executor.rs Outdated Show resolved Hide resolved
sylvia-derive/src/executor.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia/src/types.rs Outdated Show resolved Hide resolved
sylvia/src/types.rs Outdated Show resolved Hide resolved
sylvia/src/types.rs Outdated Show resolved Hide resolved
sylvia/src/types.rs Show resolved Hide resolved
sylvia/src/types.rs Outdated Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch from a55a69d to a26a68e Compare June 24, 2024 18:00
jawoznia
jawoznia approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM

sylvia/src/types.rs Outdated Show resolved Hide resolved
jawoznia
jawoznia reviewed Jun 26, 2024
View reviewed changes
sylvia/src/types.rs Outdated Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the tkulik/feat/executors branch from aa93431 to 00cc2ad Compare June 27, 2024 08:18
@kulikthebird kulikthebird merged commit 90af7d0 into main Jun 27, 2024
7 checks passed
@kulikthebird kulikthebird deleted the tkulik/feat/executors branch June 27, 2024 08:34
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Merged
kulikthebird added a commit that referenced this pull request Jul 12, 2024
@github-actions @kulikthebird
chore: release (#366)
18afff1 
## 🤖 New release
* `sylvia`: 1.0.2 -> 1.1.0
* `sylvia-derive`: 1.0.2 -> 1.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `sylvia-derive`
<blockquote>

##
[1.1.0](sylvia-derive-v1.0.2...sylvia-derive-v1.1.0)
- 2024-07-12

### Added
- `From` implementation for contract messages of interface messages
([#391](#391))
- Attributes forwarding to message enums and fields
([#388](#388))
- Executors ([#386](#386))
- No ref needed for 'dyn Interface' type in Remote and BoundQuerier
([#382](#382))
- Remove types forwarding to interface in sv::messages
([#361](#361))

### Other
- Update documentation and refactoring
([#393](#393))
- Add trybuild check for two instantiate methods
([#392](#392))
- Update dependecies
- Update proc-macro-crate deps
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <[email protected]>
blaze00193 pushed a commit to blaze00193/CosmWasm-smart-contract that referenced this pull request Sep 26, 2024
@github-actions @kulikthebird
chore: release (#366)
a43bb1d 
## 🤖 New release
* `sylvia`: 1.0.2 -> 1.1.0
* `sylvia-derive`: 1.0.2 -> 1.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `sylvia-derive`
<blockquote>

##
[1.1.0](CosmWasm/sylvia@sylvia-derive-v1.0.2...sylvia-derive-v1.1.0)
- 2024-07-12

### Added
- `From` implementation for contract messages of interface messages
([#391](CosmWasm/sylvia#391))
- Attributes forwarding to message enums and fields
([#388](CosmWasm/sylvia#388))
- Executors ([#386](CosmWasm/sylvia#386))
- No ref needed for 'dyn Interface' type in Remote and BoundQuerier
([#382](CosmWasm/sylvia#382))
- Remove types forwarding to interface in sv::messages
([#361](CosmWasm/sylvia#361))

### Other
- Update documentation and refactoring
([#393](CosmWasm/sylvia#393))
- Add trybuild check for two instantiate methods
([#392](CosmWasm/sylvia#392))
- Update dependecies
- Update proc-macro-crate deps
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawoznia jawoznia jawoznia approved these changes

Assignees

@kulikthebird kulikthebird

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kulikthebird @jawoznia