Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pinning a contract that is already pinned is cheap #808

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Ensure pinning a contract that is already pinned is cheap #808

merged 2 commits into from
Mar 1, 2021

Conversation

webmaster128
Copy link
Member

Closes #806

@webmaster128 webmaster128 requested a review from maurolacy March 1, 2021 20:23
maurolacy
maurolacy approved these changes Mar 1, 2021
View reviewed changes
packages/vm/src/cache.rs
assert_eq!(cache.stats().hits_pinned_memory_cache, 0);
assert_eq!(cache.stats().hits_memory_cache, 1);
assert_eq!(cache.stats().hits_fs_cache, 1);
assert_eq!(cache.stats().misses, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests.

@webmaster128 webmaster128 added the automerge See mergify.io label Mar 1, 2021
@mergify mergify bot merged commit b190a52 into main Mar 1, 2021
@mergify mergify bot deleted the pinned_memory_cache-has branch March 1, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
automerge See mergify.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it cheep to pin a contract that is already pinned
2 participants
@webmaster128 @maurolacy