Add some failure modes to hackatom contract #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
force-pushed
the
hackatom-with-failure-modes
branch
from
78759c4 to
fdb5ec1
Compare
9 tasks
webmaster128
reviewed
Feb 7, 2020
I wanted this primarily to test the soon-to-be released wasmd binary, so you, need it on 0.6. It should be merged into 0.7 as well. This doesn't break any APIs, just changes the format of the test contract (but nothing but our test code should depend on that) |
|
Okay, I believe I fixed all points from the review |
webmaster128
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this discussion: CosmWasm/wasmd#8 (comment)
Breaking change in the contract - no longer will
{}release funds, but we will need to do{"release":{}}.We add the following new commands for testing the stack:
{"cpuloop":{}}- will do an infinite loop with cpu usage - to hit wasm gas limit{"storageloop":{}}- will do an infinite loop with writes to storage - to hit cosmos-sdk storage gas limit{"panic":{}}- will cause contract to do a panic, make sure we handle this properly (like any other error)