Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign channel types for ibc_channel_open #1008

Merged
merged 7 commits into from
Jul 19, 2021
Merged

Redesign channel types for ibc_channel_open #1008

merged 7 commits into from
Jul 19, 2021

Conversation

uint
Copy link
Contributor

@uint uint commented Jul 15, 2021 •
edited
Loading

I started working on #888. Open draft for now as the discussion continues and we experiment with this.

Note to update the docs:

  • CHANGELOG.md
  • IBC.md
  • MIGRATING.md?

Closes #1010

@uint uint requested review from webmaster128 and ethanfrey July 15, 2021 08:15
ethanfrey
ethanfrey previously requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start. Let's use the initiator arg to make things cleaner

packages/std/src/ibc.rs Outdated Show resolved Hide resolved
contracts/ibc-reflect/tests/integration.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/mock.rs Outdated Show resolved Hide resolved
@uint
Copy link
Contributor Author

uint commented Jul 15, 2021

After today's discussion, I think all the comments here are obsolete, so I'm resolving them. Code incoming...

@uint
Copy link
Contributor Author

uint commented Jul 15, 2021

The package_vm failure is just a matter of recompiling ibc_reflect. I'll do that last so we don't proliferate those files more than necessary in git history.

@uint uint requested review from webmaster128 and ethanfrey July 15, 2021 17:16
ethanfrey
ethanfrey reviewed Jul 15, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. And far more complete than I thought you could do today.

contracts/ibc-reflect-send/src/ibc.rs Show resolved Hide resolved
contracts/ibc-reflect-send/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/mock.rs Show resolved Hide resolved
webmaster128
webmaster128 reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/mock.rs Show resolved Hide resolved
packages/std/src/mock.rs Show resolved Hide resolved
@webmaster128 webmaster128 requested a review from ethanfrey July 19, 2021 08:44
@uint uint requested a review from webmaster128 July 19, 2021 10:20
@uint uint marked this pull request as ready for review July 19, 2021 10:20
@uint uint dismissed ethanfrey’s stale review July 19, 2021 10:54

Those suggestions are no longer relevant with the new direction we've taken

webmaster128
webmaster128 reviewed Jul 19, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
@uint uint force-pushed the different-channel-types branch from d5cab2c to c9d8088 Compare July 19, 2021 11:36
webmaster128
webmaster128 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@webmaster128 webmaster128 merged commit d1256a4 into main Jul 19, 2021
@webmaster128 webmaster128 deleted the different-channel-types branch July 19, 2021 12:07
@uint uint mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Richer Ibc*Msg types
3 participants
@uint @webmaster128 @ethanfrey