Merge mistakes #42
Merged
Merge mistakes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brought back charge field Fixed code that was erroring in Model (indices for mtx were wrong)
Updated the AnyonModel enum from the old python version to the new rust version
github.com:Cornell-QCA/anyon-braiding-simulator
rbyrne299
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Looks great, thanks @Haadi-Khan!
Minor thing: I removed the anyon and model commands from the commands displayed when user inputs help, but you added them back. Even though this is handled when checking the init_complete flag, I didn't see any reason to confuse the user by providing these as options, since they'll never be used after initialization. Lmk if there's a reason you added them back, otherwise I'll update in my next PR (leaving it for now since it's small).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.