Skip to content

Commit

Permalink
🧼 Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
JulesFouchy committed Dec 23, 2024
1 parent 3faeb5d commit 7438405
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions src/Version/VersionManager.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ class VersionManager {
void imgui_manage_versions();
void imgui_versions_dropdown(VersionRef&);

auto latest_version_no_locking() -> Version*;
auto latest_installed_version_no_locking() -> Version*;

private:
auto find_no_locking(VersionName const& name) -> Version*;
void with_version_found(VersionName const& name, std::function<void(Version&)> const& callback);
Expand All @@ -25,10 +28,6 @@ class VersionManager {
void install(Version const&);
void uninstall(Version&);

public: // TODO(Launcher)
auto latest_version_no_locking() -> Version*;
auto latest_installed_version_no_locking() -> Version*;

private:
friend class Task_FetchListOfVersions;
friend class Task_WaitForDownloadUrlToInstallVersion;
Expand Down
4 changes: 2 additions & 2 deletions src/Version/VersionName.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "VersionName.hpp"
#include <cassert>
#include <compare>
#include "VersionName.hpp"


static auto is_number(char c) -> bool
{
Expand Down Expand Up @@ -31,7 +32,6 @@ VersionName::VersionName(std::string name)
}
catch (...)
{
// TODO(Launcher) Handle errors better
_is_valid = false;
return;
}
Expand Down

0 comments on commit 7438405

Please sign in to comment.