Merge pull request #86 from ConvertAPI/feature/remove-alternative-con…

…verter Remove alternative converter support
ConvertAPI · Sep 14, 2024 · ab9efb6 · ab9efb6
2 parents 3fc2cbe + fe757d8
commit ab9efb6
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 40 deletions.
diff --git a/examples/alternative_converter.js b/examples/alternative_converter.js
diff --git a/src/task.js b/src/task.js
@@ -2,7 +2,6 @@ import {
   normalizeFilesParam,
   buildFileParam,
   detectFormat,
-  detectConverter,
 } from './utils';
 import Result from './result';
 
@@ -27,9 +26,7 @@ const Task = class {
     }
 
     const fromFormat = this.fromFormat || detectFormat(params, this.toFormat);
-    const converter = detectConverter(params);
-    const converterPath = converter ? `/converter/${converter}` : '';
-    const path = `convert/${fromFormat}/to/${this.toFormat}${converterPath}`;
+    const path = `convert/${fromFormat}/to/${this.toFormat}`;
     const response = await this.api.client.post(path, params, timeout);
 
     return new Result(this.api, response);

diff --git a/src/utils.js b/src/utils.js
@@ -109,11 +109,3 @@ export const encodeFileName = (fileName) => {
   const str = encodeURIComponent(fileName);
   return str.replace(/[!'()*]/g, c => `%${c.charCodeAt(0).toString(16)}`);
 };
-
-export const detectConverter = (params) => {
-  const converterKey = Object.keys(params).find(key => key.toLowerCase() === 'converter');
-
-  if (!converterKey) return undefined;
-
-  return params[converterKey];
-};
diff --git a/test/index.js b/test/index.js
@@ -76,13 +76,6 @@ describe('ConvertAPI', () => {
     expect(result.file.url).to.be.a('string');
   });
 
-  it ('should convert file using alternative converter', async () => {
-    const params = { File: 'https://cdn.convertapi.com/cara/testfiles/document.docx?test=1', converter: 'openoffice' };
-    const result = await api.convert('pdf', params);
-
-    expect(result.file.url).to.be.a('string');
-  });
-
   it('should convert url to pdf', async () => {
     const params = { Url: 'http://convertapi.com' };
     const result = await api.convert('pdf', params, 'web');