Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to native HttpClient in Olog ES #3219

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Switch to native HttpClient in Olog ES #3219

merged 2 commits into from
Dec 26, 2024

Conversation

georgweiss
Copy link
Collaborator

@georgweiss georgweiss commented Dec 20, 2024

The notion of request filters supported in Jersey seems to be missing from the native APIs. In the case of the Olog client this means:

  • Permissive host name settings is implemented through call to System.getProperties().setProperty(). Unfortunately I do not have a setup to verify that this works.
  • The debugging filter would be replaced by JVM options, see jdk.httpclient.HttpClient.log. Sadly that does not provide the same functionality: request/response body not logged even at highest debug level settings.
  • Authentication filter based on username/password from properties file I have removed as I (erroneously?) see it as legacy and not needed.

Copy link
Member

@shroffk shroffk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

I think I might have to add some more flexible hostname verification

@shroffk shroffk merged commit fe6c619 into master Dec 26, 2024
3 checks passed
@georgweiss georgweiss deleted the CSSTUDIO-2646 branch December 28, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants