doc: show full preference names #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual package is |
mdavidsaver
force-pushed
the
show-pref-names
branch
from
7835faa to
5739328
Compare
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow on to #3187. Prepend package names when generating
preference_properties.htmlso they appear complete, because clearly users will copy+paste without reading the page preamble.I couldn't immediately see a way to compute the package name from the preferences file name, so I opt to parse out the
# Package ...line present in (almost) all files. This parsing is simplistic, looking at the first non-space character. It also can not fix preference names which appear in comments.Did I guess the correct package for
app/databrowser-json/src/main/resources/archive_reader_json_preferences.properties?