CSSTUDIO-2555 Bugfix: edit the source of log entries (if available), not the description of log entries. #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not the description of log entries.
abrahamwolk
requested review from
kasemir,
shroffk,
georgweiss and
thelarsjohansson
shroffk
approved these changes
Aug 20, 2024
|
Ah, |
konrad-gajewski
added a commit
to freia-lab/phoebus
that referenced
this pull request
Aug 30, 2024
…g entries (if available), not the description of log entries. ControlSystemStudio#3115).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a change to the Edit window of the logbook application: the result of
getSource()is used (if available) instead of the result ofgetDescription(). As a consequence, editing formatted logs is easier: formatting (such as headings, etc.) is not lost when editing a log entry, and does not have to be recreated again.To provide a concrete example, consider the following log-entry:
Currently (without this PR), when editing this log-entry, it would appear as
and the formatting has to be recreated.