Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro values are not replaced correctly #3004

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

lcaouen
Copy link
Contributor

@lcaouen lcaouen commented Apr 30, 2024

This is a solution to solve the issue #2945
This is not the best solution as I don't know Phoebus code so much.
Maybe we can find a better way to do it.

Copy link
Collaborator

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To replace macros, use this which handles both $(..) and ${...} and supports escaped dollar signs:

strBuffer = MacroHandler. replace(macros, strBuffer);

using MacroHandler.replace instead of "for"
@kasemir kasemir merged commit 4f977be into ControlSystemStudio:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants