Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2046 Bugfixes: decode escaped characters in URIs in two places. #2863

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

abrahamwolk
Copy link
Collaborator

This PR adds decoding of escaped characters in URIs to:

  1. The constructor of DisplayInfo. As a consequence, Phoebus is able to locate already-opened instances of OPIs that contain spaces in their filenames.
  2. The method DockItemWithInput.setInput(), so that tool-tips of tabs containing instances of DockItemWithInput don't contain escaped characters.

@abrahamwolk abrahamwolk changed the title CSSTUDIO-2046 Bugfixes: descode escaped characters in URIs in two places. CSSTUDIO-2046 Bugfixes: decode escaped characters in URIs in two places. Nov 9, 2023
Copy link
Collaborator

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the thing is that 6 years ago we changed from getRawPath() to getPath() to "Preserve '%20' encoding of space in file name",
c173ee5
Maybe this is change is good for another 6 years?

@abrahamwolk
Copy link
Collaborator Author

Well, the thing is that 6 years ago we changed from getRawPath() to getPath() to "Preserve '%20' encoding of space in file name", c173ee5 Maybe this is change is good for another 6 years?

I am not familiar with the intention of that commit; do you think that the issue that commit fixed will re-emerge with the changes in this PR?

@kasemir
Copy link
Collaborator

kasemir commented Nov 9, 2023

I don't know. 6 years ago, the fix for spaces in filenames was the exact opposite of what you do now, but some other details have changed over that time. I'm fine with merging this, and if new issues arise, you'll fix them as they become clearer. Simply avoiding spaces in file names will of course always work.

@abrahamwolk abrahamwolk merged commit fae097d into master Nov 10, 2023
2 checks passed
@abrahamwolk abrahamwolk deleted the CSSTUDIO-2046 branch November 10, 2023 08:29
@abrahamwolk
Copy link
Collaborator Author

Alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants