Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splash screen added and ui updated and timer bug fixed #6

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

Crisonel
Copy link

@Crisonel Crisonel commented Oct 10, 2024

Description

Added a new activity for splash screen and new xml file
used handler in SplashActivity.java to make the splash screen last long for 2 sec and then move to mainactivity
theme updated new appealing colors
both for light and dark mode
added the ui of toolbar for switching theme(only ui)
transition added to fragment change
animation added to button for showing click

FIXED BUG OF TIMER - earlier if timer is working and you click it starts flickering
resolved it and made the timer for 2 minutes

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

FIXED BUG OF TIMER - earlier if timer is working and you click it starts flickering
resolved it and made the timer for 2 minutes

Fixes # (issue)#1
(issue)#5
(issue)#2

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

The addition of splash screen makes the user experience better and new theme added

How Has This Been Tested?

since the app is small i added the feature and ran the app in a physical device of Android version 12

Screenshots (if appropriate):

splash screen
WhatsApp Image 2024-10-11 at 1 13 11 PM

dark mode:
1000023234
1000023236

light mode:
1000023231

toolbar menu:(only ui currently not functional)
1000023230

Checklist:

  • [ x] I have registered myself at Contrihub website.
  • [x ] My code follows the code style of this project.
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test Configuration:

  • Firmware version:
  • Hardware:Galaxy A21S
  • Toolchain:
  • SDK:Android SDK 28

@mukul-dev
Copy link
Collaborator

@Crisonel Great use of "Handler.postDelayed" for the delay! However, consider using other possible methods for implementing this feature like you can create a different activity set it as entry point of app and then move to the MainActivity. Also setting theme inside oncreate() method may cause flickering...
I tested this code in two phones natively and results were quite different, and I tried adding delay of 3 seconds, 5 seconds or so but it was not reflected upon running... so now you try to solve these issues!
Also, you can check out more resources for adding basic animations for logo (a simple zoom in/ zoom out), anything you like about it... for some bonus points too...
Overall, I appreciate your work, but it could be better... you have time left still, so you can get back with a better solution!

@Crisonel Crisonel closed this Oct 11, 2024
@Crisonel Crisonel reopened this Oct 11, 2024
@Crisonel Crisonel changed the title Added the feature of splash screen to the app that lasts for 2 sec as specified splash screen added and ui updated Oct 11, 2024
@Crisonel
Copy link
Author

@mukul-dev
Please check my PR for issue 1 and 5 for github

@mukul-dev
Copy link
Collaborator

@mukul-dev Please check my PR for issue 1 and 5 for github

Yes i reviewed and accepted for the first issue! The second is regarding UI so its still opened as it can be improved.. few things that i viewed as of now is ... The Tab bar on the top of fragments is not uniform in the two implemented fragments in one of them is centred and in other its at bottom (the text specifically) so that need to be improved.. in the calendar selected date is circled dark purple and text is dark too so you can try out experimentally with more appealing color combinations!

@Crisonel Crisonel closed this Oct 11, 2024
@Crisonel Crisonel reopened this Oct 11, 2024
@Crisonel
Copy link
Author

@mukul-dev Please check my PR for issue 1 and 5 for github

Yes i reviewed and accepted for the first issue! The second is regarding UI so its still opened as it can be improved.. few things that i viewed as of now is ... The Tab bar on the top of fragments is not uniform in the two implemented fragments in one of them is centred and in other its at bottom (the text specifically) so that need to be improved.. in the calendar selected date is circled dark purple and text is dark too so you can try out experimentally with more appealing color combinations!

@mukul-dev i have changed the color scheme for light mode
added a toolbar menu for changing theme (only ui)
fixed the timer bug earlier if you press start while the timer is running it would flicker now it does not flicker and timer runs smoothly, also now it runs for 2 min.
adjusted the toolbar text and height problem
instead of creating it in each fragment i created it in activitiy_main.xml and updating it with the java code

Please review my PR for issue (issue)#5 as well as (issue)#2 and the timer bug that i resolved

@Crisonel Crisonel changed the title splash screen added and ui updated splash screen added and ui updated and timer bug fixed Oct 11, 2024
@mukul-dev
Copy link
Collaborator

@mukul-dev i have changed the color scheme for light mode added a toolbar menu for changing theme (only ui) fixed the timer bug earlier if you press start while the timer is running it would flicker now it does not flicker and timer runs smoothly, also now it runs for 2 min. adjusted the toolbar text and height problem instead of creating it in each fragment i created it in activitiy_main.xml and updating it with the java code

Please review my PR for issue (issue)#5 as well as (issue)#2 and the timer bug that i resolved

The UI is much better, 2 min Timer also is working good (it has something that will be raised as a new issue but for now its working as expected!), Smartly set the toolbar too text too, I am merging this!

Can you mention what changes do we see upon clicking Light mode/ dark mode in the menu so that i can review and raise issue (if any) afterwards..

@mukul-dev mukul-dev merged commit c2a8b47 into ContriHUB:main Oct 11, 2024
@Crisonel
Copy link
Author

@mukul-dev I didn't get the time to make them functional and it was also not required in issue it was optional feature.
Currently they do not function

Objective is to
If you click on light mode theme will be changed to light
And if you click on dark mode so it changes to dark theme.

@mukul-dev
Copy link
Collaborator

Yes, it was optional! Make a PR regarding the bug #2 on the portal so that it can be closed, and points can be allotted. Keep up the good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants