-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splash screen added and ui updated and timer bug fixed #6
Conversation
@Crisonel Great use of "Handler.postDelayed" for the delay! However, consider using other possible methods for implementing this feature like you can create a different activity set it as entry point of app and then move to the MainActivity. Also setting theme inside oncreate() method may cause flickering... |
@mukul-dev |
Yes i reviewed and accepted for the first issue! The second is regarding UI so its still opened as it can be improved.. few things that i viewed as of now is ... The Tab bar on the top of fragments is not uniform in the two implemented fragments in one of them is centred and in other its at bottom (the text specifically) so that need to be improved.. in the calendar selected date is circled dark purple and text is dark too so you can try out experimentally with more appealing color combinations! |
@mukul-dev i have changed the color scheme for light mode Please review my PR for issue (issue)#5 as well as (issue)#2 and the timer bug that i resolved |
The UI is much better, 2 min Timer also is working good (it has something that will be raised as a new issue but for now its working as expected!), Smartly set the toolbar too text too, I am merging this! Can you mention what changes do we see upon clicking Light mode/ dark mode in the menu so that i can review and raise issue (if any) afterwards.. |
@mukul-dev I didn't get the time to make them functional and it was also not required in issue it was optional feature. Objective is to |
Yes, it was optional! Make a PR regarding the bug #2 on the portal so that it can be closed, and points can be allotted. Keep up the good work 👍 |
Description
Added a new activity for splash screen and new xml file
used handler in SplashActivity.java to make the splash screen last long for 2 sec and then move to mainactivity
theme updated new appealing colors
both for light and dark mode
added the ui of toolbar for switching theme(only ui)
transition added to fragment change
animation added to button for showing click
FIXED BUG OF TIMER - earlier if timer is working and you click it starts flickering
resolved it and made the timer for 2 minutes
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Related Issue
FIXED BUG OF TIMER - earlier if timer is working and you click it starts flickering
resolved it and made the timer for 2 minutes
Fixes # (issue)#1
(issue)#5
(issue)#2
Type of change
Motivation and Context
The addition of splash screen makes the user experience better and new theme added
How Has This Been Tested?
since the app is small i added the feature and ran the app in a physical device of Android version 12
Screenshots (if appropriate):
splash screen
dark mode:
light mode:
toolbar menu:(only ui currently not functional)
Checklist:
Test Configuration: