Log all loads + updates #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no longer support --require (only supports node 18.19.0+) - add primordials for a couple methods that are used in the patcher - add cpuUser and cpuSystem (monotonically increasing values) to averages - add route-metric's version number to the header - fix first/last times - add express.mjs to the test matrix - pass relevant env to loader thread - remove artifact "metrics" usage (replaced by "routes")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--importunless node version < 18.19.0.Note that the updates to work with ESM just lets the tests pass; it does not work quite right for node versions 18.19.0 up to 20.0.0 (really 20.6.0 because node's ESM loader was fubar from 20.0.0 to 20.6.0). And it will miss modules loaded with import statements or the
importfunction until ESM support is added.testing changes
N.B.:
this fixes the testing ordering problems and makes tests much more maintainable. I am adding ESM support, based on this branch, and will rebase it on main if this is merged.