Remove --single-process flag #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is causing Puppeteer to hang on recent Alpine / Chromium, see: puppeteer/puppeteer#11640 (comment) puppeteer/puppeteer#11640 (comment)
dkanas
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is causing Puppeteer to hang on recent Alpine / Chromium, see:
puppeteer/puppeteer#11640 (comment)
puppeteer/puppeteer#11640 (comment)
I believe this flag was added in order to prevent excessive Chromium zombie processes. Currently, there's https://github.com/Contractbook/file_service/pull/645 that ensures number of dead process don't go out of hand by restarting file-service in production every 6 hours.
I'm choosing to trade the flag for running more up-to-date version of Chromium + Alpine for file service. Separately, if we want to make the situation with zombie processes better, we should revisit
erlexecapproach: https://github.com/Contractbook/file_service/pull/735.