Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade networking api in ingress and use new syntax #39

Merged
merged 3 commits into from
May 6, 2022
Merged

Upgrade networking api in ingress and use new syntax #39

merged 3 commits into from
May 6, 2022

Conversation

kolja-lucht
Copy link
Contributor

This PR upgrades the api version for networking.k8s.io in the ingress example from v1beta to v1.
Version v1beta is deprecated in kubernetes v1.19+ and will be unavailable in v.1.22+. Since this brings a slight syntax change I thought it would make sense to update your ingress examples so that they would be compatible with the currently supported kubernetes versions.
Looking forward to your review 🙂

@kolja-lucht
Copy link
Contributor Author

@ianmiell I saw that you merged the last PRs and took care of the latest release as well. Hope you're the right person to tag here 🙂 Just wanted to make sure that somebody is aware of this PR.

@kolja-lucht
Copy link
Contributor Author

Looping in @sebagomez now, since you're part of the Container Solutions org.
Would you be able to review this PR or at least assign it to the right person? Because not much has happened in this project for a little while, I'm not sure who else I could tag...

@kolja-lucht
Copy link
Contributor Author

Are there any updates regarding this @sebagomez? 🙃
The other day I finally figured out from whom I learned about this repo. His name is Gustavo Carvalho and he presented this (and two other repos from container solutions) in the official hacktoberfest kickoff call on zoom early this month. Unfortunately I don't know his github handle, otherwise I would've tagged him. Maybe you know him and could reach out to him in case he's able to review this?

@sebagomez
Copy link
Contributor

Sorry, been super busy.
I'll tag Gustavo (@gusfcarvalho) and I'll personally reach out to him and see if he has time for it.

@gusfcarvalho
Copy link

Thank you for your contribution @kolja-lucht! From what I've seen this update looks awesome! There seems to be an issue with our ci process. I'll check with more senior people within container solutions if they know how to go over it.

@kolja-lucht
Copy link
Contributor Author

Great, thanks @gusfcarvalho 🙂

@ianmiell ianmiell merged commit 1875537 into ContainerSolutions:master May 6, 2022
@ianmiell
Copy link
Collaborator

ianmiell commented May 6, 2022

Sorry about the delay on this, and thanks!

@kolja-lucht
Copy link
Contributor Author

No worries @ianmiell. Thanks for updating my branch and merging the PR! Have a nice weekend 🌞

@kolja-lucht kolja-lucht deleted the kolja/ingress_networking_api_update branch May 6, 2022 14:16
melihc1 added a commit that referenced this pull request May 10, 2023
@melihc1
Squashed 'examples/' changes from 37ba37b..5dfc652
be562e7 
5dfc652 update version references to: refs/tags/v0.0.5
1661a68 Updates for 1.27 (#62)
7216417 Remove PodSecurityPolicy examples (#59)
a5709b6 update version references to: refs/tags/v0.0.4
bd819c7 Prepare for release of v0.0.4 (#61)
d208442 test rerun
5b6816c Merge pull request #55 from eminalemdar/master
b17cd9e updated kubeconform command for correcting the errors about Istio, PSP and CRDs
f29c136 Merge pull request #51 from eminalemdar/api-version-updates
4c8bcdb Updated restricted PodSecurityPolicy example
a6f2d88 Updated PodDisruptionBudget examples
a2bdcd5 Updated EndpointSlice example
42dcf1d Updated Cron Job example
897a020 Merge pull request #48 from ContainerSolutions/custom-resource-definition
03d3d0d fix yamllint offences
f47dd48 Add a CRD example
f63018f Update RELEASE_PROCESS.md
1875537 Merge pull request #39 from kolja-lucht/kolja/ingress_networking_api_update
9ce140f Add new line to end of files
998c4ba Merge branch 'master' into kolja/ingress_networking_api_update
d2b6ddd Merge pull request #47 from ContainerSolutions/pr42
04059dd Yaml lints
aea771a Add README for VirtualServices
5958eb6 Examples for Istio VirtualService.networking.istio.io/v1beta1
9e8ca44 Ignore missing schemas
c55be3e Merge pull request #43 from mt-inside/istio-destinationrule
c1440bc Merge pull request #46 from ContainerSolutions/update
10f6564 Ingress and other schema update corrections
212803d Merge pull request #44 from ContainerSolutions/kubeconform
5b09f5a Merge pull request #45 from ContainerSolutions/remove-podpreset
64f8c22 removing PodPreset example
ed31e7c changed error condition
cbb7fb1 changed kubeval to kubeconform
5eb9183 Merge pull request #41 from shteou/patch-1
8e64c56 Add simple examples of DestinationRules
f4817d5 fix: typo in pod's volume claimName
8923810 Upgrade networking api in ingress and use new syntax
cdf024a Logo and release
c1446f0 Release
1413a43 logo
a0b1581 Merge pull request #36 from ContainerSolutions/feature-add-deployment-environment
a3498cb Fix lint empty space error
5538109 Add Deployment example with environment variables

git-subtree-dir: examples
git-subtree-split: 5dfc652
melihc1 added a commit that referenced this pull request May 10, 2023
@melihc1
Kubernetes examples UI update 5dfc652 100523 (#63)
28bac00 
* Squashed 'examples/' changes from 37ba37b..5dfc652

5dfc652 update version references to: refs/tags/v0.0.5
1661a68 Updates for 1.27 (#62)
7216417 Remove PodSecurityPolicy examples (#59)
a5709b6 update version references to: refs/tags/v0.0.4
bd819c7 Prepare for release of v0.0.4 (#61)
d208442 test rerun
5b6816c Merge pull request #55 from eminalemdar/master
b17cd9e updated kubeconform command for correcting the errors about Istio, PSP and CRDs
f29c136 Merge pull request #51 from eminalemdar/api-version-updates
4c8bcdb Updated restricted PodSecurityPolicy example
a6f2d88 Updated PodDisruptionBudget examples
a2bdcd5 Updated EndpointSlice example
42dcf1d Updated Cron Job example
897a020 Merge pull request #48 from ContainerSolutions/custom-resource-definition
03d3d0d fix yamllint offences
f47dd48 Add a CRD example
f63018f Update RELEASE_PROCESS.md
1875537 Merge pull request #39 from kolja-lucht/kolja/ingress_networking_api_update
9ce140f Add new line to end of files
998c4ba Merge branch 'master' into kolja/ingress_networking_api_update
d2b6ddd Merge pull request #47 from ContainerSolutions/pr42
04059dd Yaml lints
aea771a Add README for VirtualServices
5958eb6 Examples for Istio VirtualService.networking.istio.io/v1beta1
9e8ca44 Ignore missing schemas
c55be3e Merge pull request #43 from mt-inside/istio-destinationrule
c1440bc Merge pull request #46 from ContainerSolutions/update
10f6564 Ingress and other schema update corrections
212803d Merge pull request #44 from ContainerSolutions/kubeconform
5b09f5a Merge pull request #45 from ContainerSolutions/remove-podpreset
64f8c22 removing PodPreset example
ed31e7c changed error condition
cbb7fb1 changed kubeval to kubeconform
5eb9183 Merge pull request #41 from shteou/patch-1
8e64c56 Add simple examples of DestinationRules
f4817d5 fix: typo in pod's volume claimName
8923810 Upgrade networking api in ingress and use new syntax
cdf024a Logo and release
c1446f0 Release
1413a43 logo
a0b1581 Merge pull request #36 from ContainerSolutions/feature-add-deployment-environment
a3498cb Fix lint empty space error
5538109 Add Deployment example with environment variables

git-subtree-dir: examples
git-subtree-split: 5dfc652

* add release.sh to check example markdowns

* add version for theme

* add missing markdowns

* ignore bin for markdown check

* cleanup

* added check for directories without yamls

* updated Gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kolja-lucht @sebagomez @gusfcarvalho @ianmiell